You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/21 13:48:03 UTC

[GitHub] [lucene-solr] epugh opened a new pull request #1898: Solr 14882

epugh opened a new pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898


   Fixing up the .jsonl versus .json format on `bin/solr export`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] arafalov commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696160912






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] noblepaul commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
noblepaul commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696676802


   can you please add a title?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696299309


   Okay, turns out my not loading json was due to something odd in the sample data I exported (sigh)...  However, the more_books.jsonl works just fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696292278


   Okay, working on testing the CURL commands in the solr-control-script-reference.adoc...    I am not able to do this:
   
   ```
   curl -X POST -d @big.jsonl http://localhost:8983/solr/dude2/update/json/docs?commit=true
   ```
   
   So, did I miss soemthing, maybe we aren't doing JSONL...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] arafalov commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696160912


   Does it actually export jsonl though? I did not test.
   
   Also, while we are correcting all of these, can we fix the "usage line" that currently seems to fallback to SolrCLI:
   > $ bin/solr export -help
   > usage: org.apache.solr.util.SolrCLI
   
   By comparison:
   > $ bin/solr create_core -help
   > Usage: solr create_core [-c core] [-d confdir] [-p port] [-V]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] noblepaul commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
noblepaul commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696676802


   can you please add a title?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696166997


   It does export `jsonl` instead of `json`!   Good thought on the help...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696284466


   Okay, so @arafalov  I am having NO luck in finding the text `usage:` or where it is comiong from...   I can live with it...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696301654


   This is why we need a full overhaul of the SolrCLI, get all this logic out of the solr shell and cmd files, and into Java, and have one way of doing everything!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] arafalov commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696296773


   > Okay, so @arafalov I am having NO luck in finding the text `usage:` or where it is comiong from... I can live with it...
   
   It helps to see where other invocations do it. So, it seems to be something about:
   ```
         if (cli.getOptions().length == 0 || cli.getArgs().length > 0 || cli.hasOption("h")) {
           new HelpFormatter().printHelp("bin/solr utils [OPTIONS]", getToolOptions(this));
           return 1;
         }
   ```
   
   This tool does not have it, so probably falls back to default implementation that constructs default message with getOptions() instead. Not the end of the world, but would have been nice to fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] madrob commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696213908


   Please add a CHANGES entry


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] madrob commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696213908


   Please add a CHANGES entry


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696166997






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh closed pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh closed pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-779373810


   I'm going to take the good parts of this PR and add them to SOLR-15152 in #2356 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696212339


   Can you check on master @arafalov as I just ran it and got help docs:
   
   ```
   ➜  solr-9.0.0-SNAPSHOT git:(SOLR-14882) bin/solr export -help                                                                       
   usage: org.apache.solr.util.SolrCLI
    -fields <arg>   Comma separated fields. By default all fields are fetched
    -format <arg>   format  jsonl/javabin, defaults to jsonl. file extension
                    will be .jsonl
    -help           Print this message
    -limit <arg>    Max number of docs to download. default = 100, use -1 for
                    all docs
    -out <arg>      file name . defaults to collection-name.<format>
    -query <arg>    A custom query, default is *:*
    -url <arg>      Address of the collection, example
                    http://localhost:8983/solr/gettingstarted
    -verbose        Generate verbose log messages
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] arafalov commented on pull request #1898: SOLR-14882

Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1898:
URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696213831


   > Can you check on master @arafalov as I just ran it and got help docs:
   > 
   > ➜  solr-9.0.0-SNAPSHOT git:(SOLR-14882) bin/solr export -help                                                                       
   > usage: org.apache.solr.util.SolrCLI
   
   ^^^^^^^^^^^^^^^^^^^
   
   Yes, it is just that first line I was commenting on. It should talk about the command, not about the java tool that executes it. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org