You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/01 22:58:43 UTC
[GitHub] [activemq-website] lucastetreault opened a new pull request #61: Cleanup AMQ-8278 changes
lucastetreault opened a new pull request #61:
URL: https://github.com/apache/activemq-website/pull/61
- Removing the per-release pages that I added for Artemis as per @jbertram's feedback
- Pointing all Artemis links in the news feed to the main download page: /components/artemis/download/
- Put the News link back in the nav bar now that that page is rendering properly: https://activemq.apache.org/news/
There will be one follow-up PR to point "old" versions of Artemis (e.g.: 2.17.0) to the past release page: https://activemq.apache.org/components/artemis/download/past_releases with an anchor to the specific version so that if someone is looking for specific information about an old release we aren't sending them somewhere unexpected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] mattrpav commented on pull request #61: Cleanup AMQ-8278 changes
Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #61:
URL: https://github.com/apache/activemq-website/pull/61#issuecomment-910877344
Leaving this PR open for 12-hrs for comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on pull request #61: Cleanup AMQ-8278 changes
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #61:
URL: https://github.com/apache/activemq-website/pull/61#issuecomment-911555955
Separately, around the noted followup PR, I really dont think the news item links should be changed to anchor to specific bits on the past releases page.
For the front-page entries I dont think it should even link to the past releases page at all, I would always go with the download page that has the current releases. For old news-page entries, I would personally do the same, though if not then I would still only link to the very top of the past releases page. Once there people can then see the immediate note these are old releases and they should go do the download page for a current release, and are presented initially with the most recent no-longer-current version. It is not hard to find/scroll to get to even older versions if you want them.
For some comparisons:
Camels release news entries dont have download links at all. You have to go to their download page independently to get anything, which only has the current supported releases. If you want an old unsupported release, there is a link to a page of old releases buried after a good chunk of initial blurb
Karaf has release news entries that all pointing to the main download page, which only has the current release. They dont link to old releases until the very bottom of the long long download page.
Kafka doesnt have new entries, and just has a single download page with everything on it, you find/scroll to get to old unsupported ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] lucastetreault closed pull request #61: Cleanup AMQ-8278 changes
Posted by GitBox <gi...@apache.org>.
lucastetreault closed pull request #61:
URL: https://github.com/apache/activemq-website/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on pull request #61: Cleanup AMQ-8278 changes
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #61:
URL: https://github.com/apache/activemq-website/pull/61#issuecomment-911540799
Should the layout file that was added go as well, i.e is it used any more?
The merge commit and resulting tangle seems unnecessary, it would be good to rebase.
The changes in #58 to the generation of the Artemis download and past-releases pages have resulted in the download page pointing at the archive instead of the mirrors, and also broken the documentation link on the download page such that it now points to a 2.18.0 dir that doesnt exist yet, as opposed to 'latest' which does and was always referenced on the download page for the current release (per comment around docs-version in the release files).
The download links need fixed, and I think its nice that the download page consistently points people to the latest docs, so I think it would be good to keep doing so there too.
(Possibly the release process should also be changed, e.g make 'latest' a symlink that is updated at the time of release, i.e to point to a 2.18.0 dir, rather than creating the version dir after the the subsequence release as currently happens).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on pull request #61: Cleanup AMQ-8278 changes
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #61:
URL: https://github.com/apache/activemq-website/pull/61#issuecomment-911610495
I rebased and pushed the changes here, along with a fixup commit https://github.com/apache/activemq-website/commit/746de9e101141dd7629fe697319bf4d6ffefa573 to resolve to the issues the earlier changes introduced as I mentioned here, and another issue I noticed with these change once I tried them (broken front page news item links as they werent updated).
I referenced #60 instead of this PR by mistake in the log message of https://github.com/apache/activemq-website/commit/746de9e101141dd7629fe697319bf4d6ffefa573 so it didnt actually close the PR out, can you close it please @lucastetreault (to avoid me doing another commit/force push to, I dont have write access on github)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org