You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by davidyan74 <gi...@git.apache.org> on 2016/04/04 21:40:07 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-419 #resolve when opera...
GitHub user davidyan74 opened a pull request:
https://github.com/apache/incubator-apex-core/pull/293
APEXCORE-419 #resolve when operator is marked blocked, print out a warning instead of debug
@PramodSSImmaneni please merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidyan74/incubator-apex-core APEXCORE-419
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit bcc9c9683792e5411329b1ac660a69fddfa37249
Author: David Yan <da...@datatorrent.com>
Date: 2016-04-04T19:39:17Z
APEXCORE-419 #resolve when operator is marked blocked, print out a warning instead of debug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-419 #resolve when opera...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-419 #resolve when opera...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/293#discussion_r58437448
--- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
@@ -1911,12 +1911,17 @@ public void updateRecoveryCheckpoints(PTOperator operator, UpdateCheckpointsCont
ctx.committedWindowId.setValue(operator.getRecoveryCheckpoint().windowId);
}
- if (operator.getState() == PTOperator.State.ACTIVE && (ctx.currentTms - operator.stats.lastWindowIdChangeTms) > operator.stats.windowProcessingTimeoutMillis) {
+ if (operator.getState() == PTOperator.State.ACTIVE &&
+ (ctx.currentTms - operator.stats.lastWindowIdChangeTms) > operator.stats.windowProcessingTimeoutMillis) {
--- End diff --
Why this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-419 #resolve when opera...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/293#issuecomment-205469590
Please check what happens after this message is logged. If the affected operators are reset, then why do we need this message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---