You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2009/06/18 19:32:07 UTC
[jira] Created: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
In DataTransferProtocol, the serialization of proxySource is not consistent
---------------------------------------------------------------------------
Key: HADOOP-6079
URL: https://issues.apache.org/jira/browse/HADOOP-6079
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Priority: Minor
In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but than the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6079:
-------------------------------------------
Status: Patch Available (was: Open)
> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
> Key: HADOOP-6079
> URL: https://issues.apache.org/jira/browse/HADOOP-6079
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but then the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722208#action_12722208 ]
Hudson commented on HADOOP-6079:
--------------------------------
Integrated in Hadoop-trunk #872 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/872/])
> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
> Key: HADOOP-6079
> URL: https://issues.apache.org/jira/browse/HADOOP-6079
> Project: Hadoop Common
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but then the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6079:
-------------------------------------------
Attachment: 6079_20090618.patch
6079_20090618.patch:
- serialize proxySource as DatanodeInfo only.
- change BalancerDatanode not to implement Writable since it is not used anywhere.
The existing TestBlockReplacement is already serializing proxySource as DatanodeInfo. So, no new test is added.
> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
> Key: HADOOP-6079
> URL: https://issues.apache.org/jira/browse/HADOOP-6079
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but than the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721450#action_12721450 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6079:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{noformat}
Ran related unit tests locally. Everything works fine.
> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
> Key: HADOOP-6079
> URL: https://issues.apache.org/jira/browse/HADOOP-6079
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but then the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721370#action_12721370 ]
Hairong Kuang commented on HADOOP-6079:
---------------------------------------
+1. I agree that serialization/deserilization should use the same type.
> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
> Key: HADOOP-6079
> URL: https://issues.apache.org/jira/browse/HADOOP-6079
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but than the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6079:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I have committed this.
> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
> Key: HADOOP-6079
> URL: https://issues.apache.org/jira/browse/HADOOP-6079
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but then the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6079) In DataTransferProtocol, the
serialization of proxySource is not consistent
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-6079:
----------------------------------
Description: In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but then the serialized value is read as a DatanodeInfo. (was: In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but than the serialized value is read as a DatanodeInfo.)
Fix Version/s: 0.21.0
Hadoop Flags: [Reviewed]
> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
> Key: HADOOP-6079
> URL: https://issues.apache.org/jira/browse/HADOOP-6079
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but then the serialized value is read as a DatanodeInfo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.