You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/07 13:42:12 UTC
[GitHub] [incubator-nuttx-testing] davids5 opened a new pull request #54: sim:Add nsh cromfs to build
davids5 opened a new pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54
## Summary
Add nsh cromfs to build testing
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] davids5 commented on a change in pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54#discussion_r467055318
##########
File path: testlist/sim.dat
##########
@@ -1,5 +1,6 @@
/sim
-sim:cxxtest
+-sim:nshcromfs
Review comment:
No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] davids5 commented on pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54#issuecomment-670556788
Ok Great. I would not have look in a different repo. I read it, but the usage is still not clear sim.dat does not follow the same pattern as shown in the documentation.
So are the lists blacklist? (i.e all configs built except for the one listed with -) or is this the list or all configs and - is a comment
How about adding something like this to the README.md?
```
To add a board to be tested do the following:
1) .....
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 edited a comment on pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54#issuecomment-670573606
> Ok Great. I would not have look in a different repo. I read it, but the usage is still not clear sim.dat does not follow the same pattern as shown in the documentation.
>
The syntax in datalist is same as the document.
> So are the lists blacklist? (i.e all configs built except for the one listed with -) or is this the list or all configs and - is a comment
>
No, basically, the list is the whitelist, but you can use - to exclude some config you don't want. # is the comment.
> How about adding something like this to the README.md?
>
> ```
> To add a board to be tested do the following:
> 1) .....
> ```
If there is something not clear to you, please improve it directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54#issuecomment-670544974
Already document here:
https://github.com/apache/incubator-nuttx/blob/master/tools/README.txt#L1043
or run ./tools/testbuild.sh -h
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54#discussion_r467049528
##########
File path: testlist/sim.dat
##########
@@ -1,5 +1,6 @@
/sim
-sim:cxxtest
+-sim:nshcromfs
Review comment:
this will disable nshcromfs build, does it your intention?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54#issuecomment-670573606
> Ok Great. I would not have look in a different repo. I read it, but the usage is still not clear sim.dat does not follow the same pattern as shown in the documentation.
>
> So are the lists blacklist? (i.e all configs built except for the one listed with -) or is this the list or all configs and - is a comment
>
No, basically, the list is the whitelist, but you can use - to exclude some config you don't want. # is the comment.
> How about adding something like this to the README.md?
>
> ```
> To add a board to be tested do the following:
> 1) .....
> ```
If there is something not clear to you, please improve it directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] davids5 closed pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
davids5 closed pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] davids5 commented on pull request #54: sim:Add nsh cromfs to build
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #54:
URL: https://github.com/apache/incubator-nuttx-testing/pull/54#issuecomment-670530347
@liuguo09 @xiaoxiang781216 How abut some documentation? Five line would be helpful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org