You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/12/20 23:46:22 UTC
[GitHub] codecov-io edited a comment on issue #3622: Start and stop ControllerPeriodicTasks based on leadership changes

codecov-io edited a comment on issue #3622: Start and stop ControllerPeriodicTasks based on leadership changes
URL: https://github.com/apache/incubator-pinot/pull/3622#issuecomment-448859489
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@39e3360`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `69.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3622/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             master   #3622   +/-   ##
   ========================================
     Coverage          ?   70.9%           
     Complexity        ?       4           
   ========================================
     Files             ?    1012           
     Lines             ?   46440           
     Branches          ?    6212           
   ========================================
     Hits              ?   32930           
     Misses            ?   11337           
     Partials          ?    2173
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...controller/helix/core/minion/PinotTaskManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvbWluaW9uL1Bpbm90VGFza01hbmFnZXIuamF2YQ==) | `86% <0%> (ø)` | `0 <0> (?)` | |
   | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `80.61% <100%> (ø)` | `0 <0> (?)` | |
   | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmV0ZW50aW9uL1JldGVudGlvbk1hbmFnZXIuamF2YQ==) | `76.62% <100%> (ø)` | `0 <0> (?)` | |
   | [...m/linkedin/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL0NvbnRyb2xsZXJTdGFydGVyLmphdmE=) | `62.28% <100%> (ø)` | `0 <0> (?)` | |
   | [...n/pinot/controller/helix/SegmentStatusChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L1NlZ21lbnRTdGF0dXNDaGVja2VyLmphdmE=) | `89.06% <100%> (ø)` | `0 <0> (?)` | |
   | [.../periodictask/ControllerPeriodicTaskScheduler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2tTY2hlZHVsZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `68.79% <100%> (ø)` | `0 <0> (?)` | |
   | [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2suamF2YQ==) | `72% <58.82%> (ø)` | `0 <0> (?)` | |
   | [...pinot/core/periodictask/PeriodicTaskScheduler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3BlcmlvZGljdGFzay9QZXJpb2RpY1Rhc2tTY2hlZHVsZXIuamF2YQ==) | `86.11% <78.57%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=footer). Last update [39e3360...5015893](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org