[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8738: Improve the Explain Plan accuracy

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8738:
URL: https://github.com/apache/pinot/pull/8738#discussion_r877549589


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -446,7 +445,7 @@ private BrokerResponseNative handleRequest(long requestId, String query, JsonNod
     }
 
     if (offlineBrokerRequest == null && realtimeBrokerRequest == null) {
-      if (pinotQuery.isExplain()) {
+      if (serverPinotQuery.isExplain()) {

Review Comment:
   We should check the broker query instead of the server query here. Server query might be the subquery of the broker query, and it might not make sense to have EXPLAIN in the subquery



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org