[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #4683: [Feature][SeaTunnel Engine] Add OSS to cluster-mode type

["EricJoy2048 (via GitHub)" <gi...@apache.org>]

EricJoy2048 commented on code in PR #4683:
URL: https://github.com/apache/incubator-seatunnel/pull/4683#discussion_r1189380470


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java:
##########
@@ -142,7 +142,7 @@ public TaskExecutionService(NodeEngineImpl nodeEngine, HazelcastProperties prope
         scheduledExecutorService = Executors.newSingleThreadScheduledExecutor();
         scheduledExecutorService.scheduleAtFixedRate(
                 this::updateMetricsContextInImap,
-                0,
+                30, // Wait for MapStore loading to complete, wait 30s

Review Comment:
   @ic4y  PTAL



##########
seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/pom.xml:
##########
@@ -30,12 +30,20 @@
     <artifactId>imap-storage-file</artifactId>
     <name>SeaTunnel : Engine : Storage : IMap Storage Plugins : File</name>
 
+    <properties>

Review Comment:
   Please add this to `pom.xml` not in submodule pom please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org