You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2016/06/15 00:43:31 UTC

Review Request 48713: RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48713/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.


Repository: ranger


Description
-------

RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath


Diffs
-----

  kms/pom.xml 9c9a606 
  pom.xml 9f04e96 
  ranger-kms-plugin-shim/.gitignore PRE-CREATION 
  ranger-kms-plugin-shim/pom.xml PRE-CREATION 
  ranger-kms-plugin-shim/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java PRE-CREATION 
  src/main/assembly/kms.xml 0598e39 
  src/main/assembly/plugin-kms.xml a0ac51f 

Diff: https://reviews.apache.org/r/48713/diff/


Testing
-------

Testing done in Local VM.


Thanks,

Ramesh Mani

Re: Review Request 48713: RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48713/#review137655
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 15, 2016, 1:43 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48713/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 1:43 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml 9c9a606 
>   pom.xml 9f04e96 
>   ranger-kms-plugin-shim/.gitignore PRE-CREATION 
>   ranger-kms-plugin-shim/pom.xml PRE-CREATION 
>   ranger-kms-plugin-shim/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java PRE-CREATION 
>   src/main/assembly/kms.xml 0598e39 
>   src/main/assembly/plugin-kms.xml a0ac51f 
> 
> Diff: https://reviews.apache.org/r/48713/diff/
> 
> 
> Testing
> -------
> 
> Testing done in Local VM.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 48713: RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48713/
-----------------------------------------------------------

(Updated June 15, 2016, 1:43 a.m.)


Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Fixed wrong interface issue


Repository: ranger


Description
-------

RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath


Diffs (updated)
-----

  kms/pom.xml 9c9a606 
  pom.xml 9f04e96 
  ranger-kms-plugin-shim/.gitignore PRE-CREATION 
  ranger-kms-plugin-shim/pom.xml PRE-CREATION 
  ranger-kms-plugin-shim/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java PRE-CREATION 
  src/main/assembly/kms.xml 0598e39 
  src/main/assembly/plugin-kms.xml a0ac51f 

Diff: https://reviews.apache.org/r/48713/diff/


Testing
-------

Testing done in Local VM.


Thanks,

Ramesh Mani

Re: Review Request 48713: RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48713/#review137647
-----------------------------------------------------------




ranger-kms-plugin-shim/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java (line 70)
<https://reviews.apache.org/r/48713/#comment202823>

    kafka.security.auth.Authorizer seems incorrect class to cast KMS authorizer. Can you please confirm?


- Madhan Neethiraj


On June 15, 2016, 12:43 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48713/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 12:43 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1034 : Ranger KMS plugin should not add depedent libraries in Ranger KMS classpath
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml 9c9a606 
>   pom.xml 9f04e96 
>   ranger-kms-plugin-shim/.gitignore PRE-CREATION 
>   ranger-kms-plugin-shim/pom.xml PRE-CREATION 
>   ranger-kms-plugin-shim/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java PRE-CREATION 
>   src/main/assembly/kms.xml 0598e39 
>   src/main/assembly/plugin-kms.xml a0ac51f 
> 
> Diff: https://reviews.apache.org/r/48713/diff/
> 
> 
> Testing
> -------
> 
> Testing done in Local VM.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>