You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Matej Knopp <ma...@knopp.sk> on 2006/10/08 14:33:10 UTC

FormComponent#DisabledAttributeModifier

What do we need that for?

Can't it be just done inside onComponentTag?

This way disabled="disabled" is always put to tag, even for SubmitLink, 
where it doesn't make sense. And there's no way to remove "disabled" in 
SubmitLink#onComponentTag, because the attribute is put there after 
onComponentTag.

-Matej

Re: FormComponent#DisabledAttributeModifier

Posted by Eelco Hillenius <ee...@gmail.com>.
Yeah, we can do that. Only disadvantage is that overriding classes
should not forget to call super, but FormComponents should do that
anyway.

Eelco


On 10/8/06, Matej Knopp <ma...@knopp.sk> wrote:
> What do we need that for?
>
> Can't it be just done inside onComponentTag?
>
> This way disabled="disabled" is always put to tag, even for SubmitLink,
> where it doesn't make sense. And there's no way to remove "disabled" in
> SubmitLink#onComponentTag, because the attribute is put there after
> onComponentTag.
>
> -Matej
>