You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by filmaj <gi...@git.apache.org> on 2017/03/16 23:42:04 UTC

[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-docs/pull/686

    CB-12559: documentation updates for new Android SDK Tools

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    Ping @infil00p, @shazron, @dpogue, @purplecabbage for review, please and thank you.
    
    Please do not merge this until apache/cordova-android#369 is merged in.
    
    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    Documents changes to set up introduced with the new Android SDK Tools.
    
    Also once-over'ed all the links and updated some of the ones to developer.android.com to avoid redirects.
    
    This incorporates / is related to #678. 
    
    ### What testing has been done on this change?
    
    Simply ran generated docs - seemed to work.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database: [CB-12559](https://issues.apache.org/jira/browse/CB-12559), [CB-12391](https://issues.apache.org/jira/browse/CB-12391), and related to the changes in [CB-12546](https://issues.apache.org/jira/browse/CB-12546) and [CB-12554](https://issues.apache.org/jira/browse/CB-12554).
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/filmaj/cordova-docs CB-12559

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #686
    
----
commit 55d356a4c96ec904d3028ba6a0e3846cb2fe3de8
Author: filmaj <ma...@gmail.com>
Date:   2017-03-16T23:34:26Z

    CB-12559: updates for new android SDK Tools. also updated links to avoid redirects. 80-character width limit honouring.

commit 176c03ca47b629d11550729b1da67a233669a517
Author: filmaj <ma...@gmail.com>
Date:   2017-03-16T23:37:18Z

    CB-12391: update android target levels for cordova-android 6.x.x

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/686#discussion_r106955951
  
    --- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
    @@ -62,19 +63,20 @@ they dip below 5% on Google's
     
     ### Java Development Kit (JDK)
     
    -Install [Java Development Kit (JDK) 7](http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html)
    +Install [Java Development Kit (JDK) 8](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html)
     or later.
     
     When installing on Windows you also need to set `JAVA_HOME` Environment Variable
     according to your JDK installation path (see [Setting Environment Variables](#setting-environment-variables))
     
     #### Android SDK
     
    -Install the [Android Stand-alone SDK Tools](http://developer.android.com/sdk/installing/index.html?pkg=tools) or [Android Studio](http://developer.android.com/sdk/installing/index.html?pkg=studio).
    -Proceed with Android Studio if you plan on
    -developing new Cordova for Android plugins or using native tools to
    -run and debug the Android platform. Otherwise, the Android Stand-alone SDK Tools
    -are enough to build and deploy Android applications.
    +Install [Android Studio](reference/cordova-plugin-camera/index.html) or the
    --- End diff --
    
    Good catch @dpogue ! Updated / simplified now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/686#discussion_r106557529
  
    --- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
    @@ -62,19 +63,20 @@ they dip below 5% on Google's
     
     ### Java Development Kit (JDK)
     
    -Install [Java Development Kit (JDK) 7](http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html)
    +Install [Java Development Kit (JDK) 8](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html)
     or later.
     
     When installing on Windows you also need to set `JAVA_HOME` Environment Variable
     according to your JDK installation path (see [Setting Environment Variables](#setting-environment-variables))
     
     #### Android SDK
     
    -Install the [Android Stand-alone SDK Tools](http://developer.android.com/sdk/installing/index.html?pkg=tools) or [Android Studio](http://developer.android.com/sdk/installing/index.html?pkg=studio).
    -Proceed with Android Studio if you plan on
    -developing new Cordova for Android plugins or using native tools to
    -run and debug the Android platform. Otherwise, the Android Stand-alone SDK Tools
    -are enough to build and deploy Android applications.
    +Install [Android Studio](reference/cordova-plugin-camera/index.html) or the
    --- End diff --
    
    Seems like the wrong link here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-docs/pull/686


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs issue #686: CB-12559: documentation updates for new Android SDK...

Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-docs/pull/686
  
    apache/cordova-android#369 has now landed, so assuming this is ready to be merged assuming there are no further issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org