You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2024/01/29 17:00:51 UTC
[PR] Fix up value types when creating range filters. (druid)
gianm opened a new pull request, #15778:
URL: https://github.com/apache/druid/pull/15778
Fixes a bug introduced in #15609, where queries involving filters on TIME_FLOOR could encounter ClassCastException when comparing RangeValue in CombineAndSimplifyBounds.
Prior to #15609, CombineAndSimplifyBounds would remove, rebuild, and re-add all numeric range filters as part of consolidating numeric range filters for the same column under the least restrictive type. #15609 included a change to only rebuild numeric range filters when a consolidation opportunity actually arises. The bug was introduced because the unconditional rebuild, as a side effect, masked the fact that in some cases range filters would be created with string match values and a LONG match value type.
This patch changes the fixup to happen at the time the range filter is initially created, rather than in CombineAndSimplifyBounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix up value types when creating range filters. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #15778:
URL: https://github.com/apache/druid/pull/15778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix up value types when creating range filters. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #15778:
URL: https://github.com/apache/druid/pull/15778#issuecomment-1915187786
This is the relevant change from the original patch: https://github.com/apache/druid/pull/15609/files#diff-77b2f7fe33af9f6ee2bddb4f5f14e80b5ce5af1f6912f481ab95f7a5a2a6263cL209-L229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org