You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/20 14:40:00 UTC
[jira] [Commented] (METRON-1628) Unable to remove alert from
metaalert in Alerts UI
[ https://issues.apache.org/jira/browse/METRON-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518208#comment-16518208 ]
ASF GitHub Bot commented on METRON-1628:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1071
METRON-1628 Unable to remove alert from metaalert in Alerts UI
The Alerts UI is unable to remove alerts from an existing metaalert. This appears to be a regression from #1049 that is similar to #1068.
<img width="1165" alt="screen shot 2018-06-20 at 10 29 01 am" src="https://user-images.githubusercontent.com/2475409/41665457-038d915e-7476-11e8-867c-93fe6d1e86e0.png">
## Testing
1. Spin-up the development environment and open the Alerts UI.
1. Create a metaalert containing one or more alerts.
1. Remove one of the alerts from the meta alert.
<img width="1165" alt="screen shot 2018-06-20 at 10 38 19 am" src="https://user-images.githubusercontent.com/2475409/41665482-112a717e-7476-11e8-827b-d2c73dd81597.png">
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1628
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1071.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1071
----
----
> Unable to remove alert from metaalert in Alerts UI
> --------------------------------------------------
>
> Key: METRON-1628
> URL: https://issues.apache.org/jira/browse/METRON-1628
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
> Attachments: Screen Shot 2018-06-20 at 10.29.01 AM.png
>
>
> To replicate, create a metaalert then attempt to remove one alert from the meta alert. This operation will fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)