[GitHub] [hudi] jp0317 commented on a diff in pull request #9650: [HUDI-6831] Add back missing project_id to query statement in BigQuerySyncTool

["jp0317 (via GitHub)" <gi...@apache.org>]

jp0317 commented on code in PR #9650:
URL: https://github.com/apache/hudi/pull/9650#discussion_r1319282103


##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/HoodieBigQuerySyncClient.java:
##########
@@ -94,8 +94,9 @@ public void createTableUsingBqManifestFile(String tableName, String bqManifestFi
       }
       String query =
           String.format(
-              "CREATE EXTERNAL TABLE `%s.%s` %s OPTIONS (%s "
+              "CREATE EXTERNAL TABLE `%s.%s.%s` %s OPTIONS (%s "
               + "uris=[\"%s\"], format=\"PARQUET\", file_set_spec_type=\"NEW_LINE_DELIMITED_MANIFEST\")",
+              projectId,

Review Comment:
   Thanks for your review! Here the project id can be skipped if the sync and data are in the same project, otherwise it's required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org