You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/29 19:21:03 UTC

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4739: Make CDN-in-a-Box enroller use latest TO client

rawlinp commented on a change in pull request #4739:
URL: https://github.com/apache/trafficcontrol/pull/4739#discussion_r432687266



##########
File path: infrastructure/cdn-in-a-box/enroller/Dockerfile
##########
@@ -17,18 +17,12 @@
 
 FROM golang:1.14.2 AS enroller-builder
 
-# enroller source and dependencies
-COPY ./lib/ /go/src/github.com/apache/trafficcontrol/lib/
-COPY ./vendor/ /go/src/github.com/apache/trafficcontrol/vendor/
-COPY ./traffic_ops/client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v2-client/

Review comment:
       I think the intention was to keep the enroller using the v2 client until it could be updated to use the v3 client (with the breaking servers changes). See https://github.com/apache/trafficcontrol/pull/4700/files#diff-1bafc9163f1489d723b8f430867c0a0dR23




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org