You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2017/09/12 01:48:21 UTC

[jclouds/jclouds] JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest (#1145)

These often fail in our continuous integration tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1145

-- Commit Summary --

  * JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest

-- File Changes --

    M core/src/test/java/org/jclouds/http/handlers/BackoffLimitedRetryHandlerTest.java (6)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1145.patch
https://github.com/jclouds/jclouds/pull/1145.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1145

Re: [jclouds/jclouds] JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest (#1145)

Posted by Ignasi Barrera <no...@github.com>.

nacx approved this pull request.

LGTM. I don't think these tests provide *real* value to the functionality of the class.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1145#pullrequestreview-62055735

Re: [jclouds/jclouds] JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest (#1145)

Posted by Andrew Gaul <no...@github.com>.

I successfully ran `mvn test -pl core` 300 times with this commit.  Previously it would fail every 10-20 times.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1145#issuecomment-328709301