You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/02 20:55:41 UTC

[GitHub] [tvm] Lunderberg commented on pull request #13542: [Logging] Mark LogFatal::~LogFatal as [[noreturn]]

Lunderberg commented on PR #13542:
URL: https://github.com/apache/tvm/pull/13542#issuecomment-1335837688

   After conversation with @kparzysz-quic , it looks like whether `[[noreturn]]` was previously applied.  https://github.com/apache/tvm/pull/11310 also added `[[noreturn]]`, but only when the `TVM_LOG_CUSTOMIZE` macro is defined.  This PR applies `[[noreturn]]` to the other branch as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org