(druid) branch master updated: fix physical memory detection on OSX (#15405)

[vo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vogievetsky pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 1df53d6eb30 fix physical memory detection on OSX (#15405)
1df53d6eb30 is described below

commit 1df53d6eb30a019fff69a5ff7533ebbd998a438d
Author: Vadim Ogievetsky <va...@ogievetsky.com>
AuthorDate: Mon Nov 20 23:19:11 2023 -0800

    fix physical memory detection on OSX (#15405)
    
    * fix physical memory detection on OSX
    
    * typo
---
 examples/bin/start-druid-main.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/bin/start-druid-main.py b/examples/bin/start-druid-main.py
index 36d07c17b67..cceb6ff60d9 100644
--- a/examples/bin/start-druid-main.py
+++ b/examples/bin/start-druid-main.py
@@ -362,7 +362,7 @@ def get_physical_memory_linux():
 
 def get_physical_memory_osx():
     p1 = subprocess.Popen(['sysctl', '-a'], stdout=subprocess.PIPE)
-    p2 = subprocess.check_output(['grep', 'hw.memsize'], stdin=p1.stdout)
+    p2 = subprocess.check_output(['grep', 'hw.memsize:'], stdin=p1.stdout)
     p2 = p2.decode('utf-8')
     fields = p2.split(':')
 
@@ -394,7 +394,7 @@ def convert_total_memory_string(memory):
             physical_memory = get_physical_memory()
 
             if physical_memory is None:
-                raise ValueError('Please specify memory argument')
+                raise ValueError('Could not automatically determine memory size. Please explicitly specify the memory argument as --memory=<integer_value><m/g>')
 
             return physical_memory
         elif memory.endswith(MEM_MB_SUFFIX):


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org