You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 03:31:27 UTC
[GitHub] [apisix] juzhiyuan opened a new pull request #2682: fix(doc): broken links
juzhiyuan opened a new pull request #2682:
URL: https://github.com/apache/apisix/pull/2682
### What this PR does / why we need it:
fix https://github.com/apache/apisix/issues/2681
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #2682: fix(doc): broken links
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #2682:
URL: https://github.com/apache/apisix/pull/2682#issuecomment-724433818
@moonming , why Travis still exist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2682: fix(doc): broken links
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2682:
URL: https://github.com/apache/apisix/pull/2682#discussion_r520274847
##########
File path: doc/README.md
##########
@@ -101,8 +100,6 @@
The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.com/cdk/) on [AWS Fargate](https://aws.amazon.com/fargate/) which helps you decouple the APISIX layer and the upstream layer on top of a fully-managed and secure serverless container compute environment with autoscaling capabilities.
-See [this guide](https://github.com/pahud/cdk-samples/blob/master/typescript/apisix/README.md) by [Pahud Hsieh](https://github.com/pahud) and learn how to provision the recommended architecture 100% in AWS CDK.
Review comment:
I have no idea what's the correct link, so I have to remove this paragraph.
cc @moonming @pahud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] pahud commented on a change in pull request #2682: fix(doc): broken links
Posted by GitBox <gi...@apache.org>.
pahud commented on a change in pull request #2682:
URL: https://github.com/apache/apisix/pull/2682#discussion_r520295949
##########
File path: doc/README.md
##########
@@ -101,8 +100,6 @@
The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.com/cdk/) on [AWS Fargate](https://aws.amazon.com/fargate/) which helps you decouple the APISIX layer and the upstream layer on top of a fully-managed and secure serverless container compute environment with autoscaling capabilities.
-See [this guide](https://github.com/pahud/cdk-samples/blob/master/typescript/apisix/README.md) by [Pahud Hsieh](https://github.com/pahud) and learn how to provision the recommended architecture 100% in AWS CDK.
Review comment:
In the long term, it would be great to provide a `cdk-apisix` CDK construct library and user experience would be like
```ts
import * as apisix from 'cdk-apisix';
const workload = new apisix.Workload();
```
And everything a standard APISIX workload on AWS will be immediately provisioned.
However, at this moment, I personally prefer we ship the document as is and remove unnecessary paragraphs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] pahud commented on a change in pull request #2682: fix(doc): broken links
Posted by GitBox <gi...@apache.org>.
pahud commented on a change in pull request #2682:
URL: https://github.com/apache/apisix/pull/2682#discussion_r520294198
##########
File path: doc/README.md
##########
@@ -101,8 +100,6 @@
The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.com/cdk/) on [AWS Fargate](https://aws.amazon.com/fargate/) which helps you decouple the APISIX layer and the upstream layer on top of a fully-managed and secure serverless container compute environment with autoscaling capabilities.
-See [this guide](https://github.com/pahud/cdk-samples/blob/master/typescript/apisix/README.md) by [Pahud Hsieh](https://github.com/pahud) and learn how to provision the recommended architecture 100% in AWS CDK.
Review comment:
No problem. Let's remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2682: fix(doc): broken links
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2682:
URL: https://github.com/apache/apisix/pull/2682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] pahud commented on a change in pull request #2682: fix(doc): broken links
Posted by GitBox <gi...@apache.org>.
pahud commented on a change in pull request #2682:
URL: https://github.com/apache/apisix/pull/2682#discussion_r525644521
##########
File path: doc/README.md
##########
@@ -101,8 +100,6 @@
The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.com/cdk/) on [AWS Fargate](https://aws.amazon.com/fargate/) which helps you decouple the APISIX layer and the upstream layer on top of a fully-managed and secure serverless container compute environment with autoscaling capabilities.
-See [this guide](https://github.com/pahud/cdk-samples/blob/master/typescript/apisix/README.md) by [Pahud Hsieh](https://github.com/pahud) and learn how to provision the recommended architecture 100% in AWS CDK.
Review comment:
ICYMI I have a video talking about what is `Contruct` in Mandarin and I compared it with the `Construct` concept in `The Matrix`. I believe you folks will love it. copy @YuanYingdong @moonming
https://www.youtube.com/watch?v=iVNs1NKWqX0&t=793s (13:13")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] pahud commented on a change in pull request #2682: fix(doc): broken links
Posted by GitBox <gi...@apache.org>.
pahud commented on a change in pull request #2682:
URL: https://github.com/apache/apisix/pull/2682#discussion_r525644521
##########
File path: doc/README.md
##########
@@ -101,8 +100,6 @@
The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.com/cdk/) on [AWS Fargate](https://aws.amazon.com/fargate/) which helps you decouple the APISIX layer and the upstream layer on top of a fully-managed and secure serverless container compute environment with autoscaling capabilities.
-See [this guide](https://github.com/pahud/cdk-samples/blob/master/typescript/apisix/README.md) by [Pahud Hsieh](https://github.com/pahud) and learn how to provision the recommended architecture 100% in AWS CDK.
Review comment:
ICYMI I have a video talking about what is `Contruct` in Mandarin and I compared it with the `Construct` concept in `The Matrix`. I believe you folks will love it.
https://www.youtube.com/watch?v=iVNs1NKWqX0&t=793s (13:13")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org