You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/01 19:26:16 UTC

[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #493: [YUNIKORN-1435] Expose RM diagnostics in full state dump

craigcondit commented on PR #493:
URL: https://github.com/apache/yunikorn-k8shim/pull/493#issuecomment-1334246723

   > changes looks good. overall test coverage needs to be improved lot specifically for each object dao inside dump.
   
   The objects themselves are simply copies of K8s objects. The new test cases verify that they are created correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org