You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "reypader (via GitHub)" <gi...@apache.org> on 2023/07/17 07:21:46 UTC
[GitHub] [incubator-pekko-connectors-samples] reypader opened a new pull request, #6: Port imports and dependencies of CSV Samples to Pekko
reypader opened a new pull request, #6:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6
Fixes #5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Port imports and dependencies of CSV Samples to Pekko [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #6: Port imports and dependencies of CSV Samples to Pekko
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-samples] mdedetrich commented on a diff in pull request #6: Port imports and dependencies of CSV Samples to Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #6:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6#discussion_r1270316372
##########
pekko-connectors-sample-http-csv-to-kafka/step_001_http_request/src/main/scala/samples/Main.scala:
##########
@@ -4,21 +4,21 @@
package samples
-import akka.Done
-import akka.actor._
-import akka.http.scaladsl._
-import akka.http.scaladsl.model.StatusCodes._
-import akka.http.scaladsl.model.headers.Accept
-import akka.http.scaladsl.model.{ HttpRequest, HttpResponse, MediaRanges }
-import akka.stream._
-import akka.stream.scaladsl.{ Sink, Source }
-import akka.util.ByteString
+import org.apache.pekko.Done
Review Comment:
Regarding scalafmt, this can be done later. For now I would just manually do the change I suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-samples] reypader commented on a diff in pull request #6: Port imports and dependencies of CSV Samples to Pekko
Posted by "reypader (via GitHub)" <gi...@apache.org>.
reypader commented on code in PR #6:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6#discussion_r1268850929
##########
pekko-connectors-sample-http-csv-to-kafka/step_001_http_request/src/main/scala/samples/Main.scala:
##########
@@ -4,21 +4,21 @@
package samples
-import akka.Done
-import akka.actor._
-import akka.http.scaladsl._
-import akka.http.scaladsl.model.StatusCodes._
-import akka.http.scaladsl.model.headers.Accept
-import akka.http.scaladsl.model.{ HttpRequest, HttpResponse, MediaRanges }
-import akka.stream._
-import akka.stream.scaladsl.{ Sink, Source }
-import akka.util.ByteString
+import org.apache.pekko.Done
Review Comment:
I've been trying to play around with my formatters and scalafmt. I copied over scalafmt from `pekko-connectors` project even. No luck. I can't seem to find formatter config that would automatically do this for me. Could you show me how?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-samples] pjfanning commented on a diff in pull request #6: Port imports and dependencies of CSV Samples to Pekko
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #6:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6#discussion_r1270853260
##########
pekko-connectors-sample-http-csv-to-kafka/common/src/main/resources/logback.xml:
##########
@@ -31,8 +31,7 @@
<logger name="org.apache" level="WARN"/>
<logger name="kafka" level="WARN"/>
- <logger name="akka" level="WARN"/>
- <logger name="akka.kafka.benchmarks" level="INFO"/>
+ <logger name="org.apache.pekko" level="WARN"/>
<logger name="org.apache.kafka.common.utils.AppInfoParser" level="ERROR"/>
Review Comment:
could you add back `<logger name="org.apache.pekko.kafka.benchmarks" level="INFO"/>` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-samples] mdedetrich commented on a diff in pull request #6: Port imports and dependencies of CSV Samples to Pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #6:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6#discussion_r1266280756
##########
pekko-connectors-sample-http-csv-to-kafka/step_001_http_request/src/main/scala/samples/Main.scala:
##########
@@ -4,21 +4,21 @@
package samples
-import akka.Done
-import akka.actor._
-import akka.http.scaladsl._
-import akka.http.scaladsl.model.StatusCodes._
-import akka.http.scaladsl.model.headers.Accept
-import akka.http.scaladsl.model.{ HttpRequest, HttpResponse, MediaRanges }
-import akka.stream._
-import akka.stream.scaladsl.{ Sink, Source }
-import akka.util.ByteString
+import org.apache.pekko.Done
Review Comment:
@reypader Pekko uses a root nested imports style, that is
```scala
import org.apache.pekko
import pekko.Done
import pekko.actor._
etc etc
```
Would you be able to update the PR to this style for all `.scala` source files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-samples] reypader commented on a diff in pull request #6: Port imports and dependencies of CSV Samples to Pekko
Posted by "reypader (via GitHub)" <gi...@apache.org>.
reypader commented on code in PR #6:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6#discussion_r1270243597
##########
pekko-connectors-sample-http-csv-to-kafka/step_001_http_request/src/main/scala/samples/Main.scala:
##########
@@ -4,21 +4,21 @@
package samples
-import akka.Done
-import akka.actor._
-import akka.http.scaladsl._
-import akka.http.scaladsl.model.StatusCodes._
-import akka.http.scaladsl.model.headers.Accept
-import akka.http.scaladsl.model.{ HttpRequest, HttpResponse, MediaRanges }
-import akka.stream._
-import akka.stream.scaladsl.{ Sink, Source }
-import akka.util.ByteString
+import org.apache.pekko.Done
Review Comment:
It looks like you have a similar thread on this specific topic https://github.com/apache/incubator-pekko/issues/414
Since this project is separate from `incubator-pekko` maybe it would be easier to enable scalafix here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Port imports and dependencies of CSV Samples to Pekko [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #6:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/6#issuecomment-1859311008
done in other PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org