[jira] [Commented] (THRIFT-3780) Fix dart int64 usage when compiled to js

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230400#comment-15230400 ] 

ASF GitHub Bot commented on THRIFT-3780:
----------------------------------------

GitHub user stevenosborne-wf opened a pull request:

    https://github.com/apache/thrift/pull/983

    THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64

    Reading/writing `i64` is broken using the binary protocol when compiled to js. Use the [`fixnum`](https://pub.dartlang.org/packages/fixnum) library to address this. Note: fixnum `Int64` is already used in the [compact protocol](https://github.com/apache/thrift/blob/master/lib/dart/lib/src/protocol/t_compact_protocol.dart#L246) to correct the same issue.
    
    @markerickson-wf

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stevenosborne-wf/thrift thrift_3780

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/983.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #983
    
----
commit acb4a4b891655544c434afad2f3491e16f2bd1ca
Author: Steven Osborne <st...@webfilings.com>
Date:   2016-04-07T15:20:59Z

    THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64

----


> Fix dart int64 usage when compiled to js
> ----------------------------------------
>
>                 Key: THRIFT-3780
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3780
>             Project: Thrift
>          Issue Type: Bug
>          Components: Dart - Library
>            Reporter: Steven
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)