You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/26 16:14:07 UTC

[GitHub] [iotdb] jun0315 commented on a change in pull request #4231: [IOTDB-1880] Compatibility of Apache IoTDB with InfluxDB - Data Record Insertion

jun0315 commented on a change in pull request #4231:
URL: https://github.com/apache/iotdb/pull/4231#discussion_r736709041



##########
File path: influxdb-protocol/src/main/java/org/apache/iotdb/influxdb/IoTDBInfluxDB.java
##########
@@ -120,12 +125,12 @@ public void writeWithRetry(final BatchPoints batchPoints) {
 
   @Override
   public void write(final String records) {
-    throw new UnsupportedOperationException(InfluxDBConstant.METHOD_NOT_SUPPORTED);
+    write(null, null, null, null, records);
   }
 
   @Override
   public void write(final List<String> records) {
-    throw new UnsupportedOperationException(InfluxDBConstant.METHOD_NOT_SUPPORTED);
+    write(String.join("\n", records));

Review comment:
       We can see the code written like this in line 514 of org/influxdb/influxdb-java/2.21/influxdb-java-2.21.jar!/org/influxdb/impl/InfluxDBImpl.class:
   
   ```java
       write(database, retentionPolicy, consistency, precision, String.join("\n", records));
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org