You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/05/05 14:14:38 UTC
[PR] [MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md [spark]
cloud-fan opened a new pull request, #55685:
URL: https://github.com/apache/spark/pull/55685
### What changes were proposed in this pull request?
Tighten the wording in `AGENTS.md` that tells coding agents to ask the user about pending changes before running tests. The previous wording fired even when the user explicitly asked for a test run.
Before:
> Build and tests can take a long time. Before running tests, ask the user if they have more changes to make.
After:
> Build and tests can take a long time. If the user explicitly asked to run tests, run them. Otherwise (you are running tests on your own to verify a change), first ask the user if they have more changes to make.
### Why are the changes needed?
The intent of the original instruction was to avoid kicking off a long, agent-initiated test run when the user has more edits coming. But as written, it also applies when the user explicitly requests a test run, which makes the prompt redundant and annoying. Spelling out both branches makes it easier for LLMs to follow the rule correctly.
### Does this PR introduce _any_ user-facing change?
No. Documentation-only update for coding agent instructions.
### How was this patch tested?
N/A — documentation only.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #55685:
URL: https://github.com/apache/spark/pull/55685#issuecomment-4384792310
thanks for the review, merging to master/4.x/4.2 (as branch 4.2 is still active before RC cut)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #55685: [MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md
URL: https://github.com/apache/spark/pull/55685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org