[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #13591: ARROW-17046 [Python] improve documentation of pyarrow.parquet.write_to_dataset function

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on code in PR #13591:
URL: https://github.com/apache/arrow/pull/13591#discussion_r921918829


##########
python/pyarrow/parquet/__init__.py:
##########
@@ -3113,9 +3117,14 @@ def file_visitor(written_file):
         dataset.  The first time each partition directory is encountered
         the entire directory will be deleted.  This allows you to overwrite
         old partitions completely.
+        This option is only supported for use_legacy_dataset=False.
     **kwargs : dict,
-        Additional kwargs for write_table function. See docstring for
-        `write_table` or `ParquetWriter` for more information.
+        When use_legacy_dataset=False, used as additional kwargs for 
+        `pyarrow.dataset.write_dataset` function (See docstring for 
+        `write_dataset` or `ParquetFileFormat` for more information).

Review Comment:
   They are actually passed to `ParquetFileFormat.make_write_options` I think, and not `write_dataset`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org