You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "xuang7 (via GitHub)" <gi...@apache.org> on 2026/10/02 01:41:26 UTC

[PR] ci: stop signing and uploading release candidates in CI [texera]

xuang7 opened a new pull request, #8813:
URL: https://github.com/apache/texera/pull/8813

   ### What changes were proposed in this PR?
   
   Remove GPG signing and the SVN upload from the release candidate workflow. CI now only builds the artifacts and checksums; the release manager signs and uploads them locally.
   
   ### Any related issues, documentation, discussions?
   
   Follows the dev@ discussion on personal keys used in CI: https://lists.apache.org/thread/4qh5mpk4bdcxtmnmvr41g366byb8z051
   
   Policy: https://infra.apache.org/release-signing.html#automated-release-signing
   
   ### How was this PR tested?
   
   Not yet dispatched; will run the workflow from this branch before merging to confirm it builds the artifacts and checksums without using GPG or SVN.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #8813:
URL: https://github.com/apache/texera/pull/8813#issuecomment-6330555956

   @xuang7 shall we move forward with this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4171516067


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,59 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
-        run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
-          echo "Verifying downloaded artifacts..."
-          ls -lh
-
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
-
-          echo "✓ All artifacts downloaded successfully"
-
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
-
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
-          else
-            # Directory doesn't exist remotely — create and add it
-            mkdir -p "$RC_DIR"
-            svn add "$RC_DIR"
-            echo "✓ Created new RC directory: $RC_DIR"
-          fi
-
-      - name: Stage artifacts to SVN
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          cd svn-texera/"$RC_DIR"
-
-          # Copy all artifacts
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            cp "$GITHUB_WORKSPACE/$artifact" .
-            cp "$GITHUB_WORKSPACE/${artifact}.asc" .
-            cp "$GITHUB_WORKSPACE/${artifact}.sha512" .
-          done
-
-          # Add files to SVN
-          svn add * --force
-
-          # Check status
-          svn status
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "✓ Staged all artifacts to SVN"
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-      - name: Commit artifacts to dist/dev
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          cd svn-texera
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-          # Commit with descriptive message
-          svn commit -m "Add Apache Texera ${VERSION} RC${RC_NUM} artifacts (source + docker-compose)" \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-          echo "✓ Committed artifacts to dist/dev/incubator/texera/$RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}
 
-      - name: Generate release summary
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          TAG_NAME="${{ needs.create-rc.outputs.tag_name }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-          COMMIT_HASH="${{ needs.create-rc.outputs.commit_hash }}"
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
-          echo "## Release Candidate Created Successfully!" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Release Information" >> $GITHUB_STEP_SUMMARY
-          echo "- **Version:** ${VERSION}" >> $GITHUB_STEP_SUMMARY
-          echo "- **RC Number:** RC${RC_NUM}" >> $GITHUB_STEP_SUMMARY
-          echo "- **Git Tag:** \`${TAG_NAME}\`" >> $GITHUB_STEP_SUMMARY
-          echo "- **Commit:** \`${COMMIT_HASH}\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Location" >> $GITHUB_STEP_SUMMARY
-          echo "**Staging Directory:** https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Created" >> $GITHUB_STEP_SUMMARY
-          echo "| Artifact | Description |" >> $GITHUB_STEP_SUMMARY
-          echo "|----------|-------------|" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${SRC_TARBALL}\` | Source code |" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${COMPOSE_TARBALL}\` | Docker Compose deployment bundle |" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "Each artifact has a corresponding \`.asc\` (GPG signature) and \`.sha512\` (checksum) file." >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Next Steps" >> $GITHUB_STEP_SUMMARY
-          echo "1. Build and push container images using the \`Build and push images\` workflow with tag \`${VERSION}\`" >> $GITHUB_STEP_SUMMARY
-          echo "2. Verify the artifacts at the staging directory" >> $GITHUB_STEP_SUMMARY
-          echo "3. Send [VOTE] email to dev@texera.apache.org" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Verification" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`bash" >> $GITHUB_STEP_SUMMARY
-          echo "# Import KEYS and verify signatures" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --import KEYS" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${SRC_TARBALL}.asc ${SRC_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${COMPOSE_TARBALL}.asc ${COMPOSE_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "# Verify SHA512 checksums" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${SRC_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${COMPOSE_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "**KEYS file:** https://downloads.apache.org/incubator/texera/KEYS" >> $GITHUB_STEP_SUMMARY
+          # 3. Commit to dist/dev with your ASF account
+          cd ..
+          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera
+          mkdir svn-texera/${RC_DIR}
+          cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/
+          svn add svn-texera/${RC_DIR}

Review Comment:
   Done in c696d412b. The runbook now checks with svn info and updates the existing RC directory instead of creating it, and uses svn add --force so re-staged files are picked up.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Create and upload release candidate artifacts
+name: Create release candidate artifacts

Review Comment:
   Agreed. This PR is from my fork, so the workflow can't be dispatched from this branch. I'll test it through the release/v1.2 backport by using it to cut 1.2.1 RC2, which is safe now that it no longer signs or uploads, and link that run here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8813:
URL: https://github.com/apache/texera/pull/8813#issuecomment-5944088616

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 2 better · 🔴 8 worse · ⚪ 5 noise (<±5%) · 0 without baseline
   
   > Compared against main `566efb8` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/36952312748)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 375 | 0.229 | 26,559/33,836/33,836 us | 🟢 -7.4% / 🔴 +120.9% |
   | 🔴 | bs=100 sw=10 sl=64 | 775 | 0.473 | 124,834/177,468/177,468 us | 🔴 +17.9% / 🔴 +69.7% |
   | ⚪ | bs=1000 sw=10 sl=64 | 917 | 0.56 | 1,088,078/1,150,671/1,150,671 us | ⚪ within ±5% / 🔴 -16.3% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `566efb8` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 375 tuples/sec | 403 tuples/sec | 829.66 tuples/sec | -6.9% | -54.8% |
   | bs=10 sw=10 sl=64 | MB/s | 0.229 MB/s | 0.246 MB/s | 0.506 MB/s | -6.9% | -54.8% |
   | bs=10 sw=10 sl=64 | p50 | 26,559 us | 24,895 us | 12,230 us | +6.7% | +117.2% |
   | bs=10 sw=10 sl=64 | p95 | 33,836 us | 36,537 us | 15,320 us | -7.4% | +120.9% |
   | bs=10 sw=10 sl=64 | p99 | 33,836 us | 36,537 us | 18,789 us | -7.4% | +80.1% |
   | bs=100 sw=10 sl=64 | throughput | 775 tuples/sec | 823 tuples/sec | 1,070 tuples/sec | -5.8% | -27.6% |
   | bs=100 sw=10 sl=64 | MB/s | 0.473 MB/s | 0.503 MB/s | 0.653 MB/s | -6.0% | -27.6% |
   | bs=100 sw=10 sl=64 | p50 | 124,834 us | 117,138 us | 97,964 us | +6.6% | +27.4% |
   | bs=100 sw=10 sl=64 | p95 | 177,468 us | 150,479 us | 104,605 us | +17.9% | +69.7% |
   | bs=100 sw=10 sl=64 | p99 | 177,468 us | 150,479 us | 113,908 us | +17.9% | +55.8% |
   | bs=1000 sw=10 sl=64 | throughput | 917 tuples/sec | 926 tuples/sec | 1,096 tuples/sec | -1.0% | -16.3% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.56 MB/s | 0.565 MB/s | 0.669 MB/s | -0.9% | -16.3% |
   | bs=1000 sw=10 sl=64 | p50 | 1,088,078 us | 1,083,600 us | 963,379 us | +0.4% | +12.9% |
   | bs=1000 sw=10 sl=64 | p95 | 1,150,671 us | 1,123,861 us | 1,001,808 us | +2.4% | +14.9% |
   | bs=1000 sw=10 sl=64 | p99 | 1,150,671 us | 1,123,861 us | 1,029,482 us | +2.4% | +11.8% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,533.99,200,128000,375,0.229,26558.92,33835.62,33835.62
   1,100,10,64,20,2580.80,2000,1280000,775,0.473,124834.19,177468.24,177468.24
   2,1000,10,64,20,21812.67,20000,12800000,917,0.560,1088077.93,1150670.52,1150670.52
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4373376967


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          echo "✓ All artifacts downloaded successfully"
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}
+
+          # 3. Commit to dist/dev with your ASF account
+          cd ..
+          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera
+          if svn info https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR} >/dev/null 2>&1; then
+            svn update --set-depth=infinity svn-texera/${RC_DIR}
           else
-            # Directory doesn't exist remotely — create and add it
-            mkdir -p "$RC_DIR"
-            svn add "$RC_DIR"
-            echo "✓ Created new RC directory: $RC_DIR"
+            mkdir svn-texera/${RC_DIR} && svn add svn-texera/${RC_DIR}
           fi
+          cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/

Review Comment:
   Done.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          echo "✓ All artifacts downloaded successfully"
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}
+
+          # 3. Commit to dist/dev with your ASF account
+          cd ..
+          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera
+          if svn info https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR} >/dev/null 2>&1; then
+            svn update --set-depth=infinity svn-texera/${RC_DIR}
           else
-            # Directory doesn't exist remotely — create and add it
-            mkdir -p "$RC_DIR"
-            svn add "$RC_DIR"
-            echo "✓ Created new RC directory: $RC_DIR"
+            mkdir svn-texera/${RC_DIR} && svn add svn-texera/${RC_DIR}
           fi
+          cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/
+          svn add --force svn-texera/${RC_DIR}
+          svn commit svn-texera -m "Add Apache Texera ${VERSION} RC${RC_NUM} artifacts (source + docker-compose)"
+          \`\`\`
 
-      - name: Stage artifacts to SVN
-        run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          cd svn-texera/"$RC_DIR"
-
-          # Copy all artifacts
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            cp "$GITHUB_WORKSPACE/$artifact" .
-            cp "$GITHUB_WORKSPACE/${artifact}.asc" .
-            cp "$GITHUB_WORKSPACE/${artifact}.sha512" .
-          done
-
-          # Add files to SVN
-          svn add * --force
-
-          # Check status
-          svn status
-
-          echo "✓ Staged all artifacts to SVN"
-
-      - name: Commit artifacts to dist/dev
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          cd svn-texera
-
-          # Commit with descriptive message
-          svn commit -m "Add Apache Texera ${VERSION} RC${RC_NUM} artifacts (source + docker-compose)" \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          echo "✓ Committed artifacts to dist/dev/incubator/texera/$RC_DIR"
-
-      - name: Generate release summary
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          TAG_NAME="${{ needs.create-rc.outputs.tag_name }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-          COMMIT_HASH="${{ needs.create-rc.outputs.commit_hash }}"
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
-          echo "## Release Candidate Created Successfully!" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Release Information" >> $GITHUB_STEP_SUMMARY
-          echo "- **Version:** ${VERSION}" >> $GITHUB_STEP_SUMMARY
-          echo "- **RC Number:** RC${RC_NUM}" >> $GITHUB_STEP_SUMMARY
-          echo "- **Git Tag:** \`${TAG_NAME}\`" >> $GITHUB_STEP_SUMMARY
-          echo "- **Commit:** \`${COMMIT_HASH}\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Location" >> $GITHUB_STEP_SUMMARY
-          echo "**Staging Directory:** https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Created" >> $GITHUB_STEP_SUMMARY
-          echo "| Artifact | Description |" >> $GITHUB_STEP_SUMMARY
-          echo "|----------|-------------|" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${SRC_TARBALL}\` | Source code |" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${COMPOSE_TARBALL}\` | Docker Compose deployment bundle |" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "Each artifact has a corresponding \`.asc\` (GPG signature) and \`.sha512\` (checksum) file." >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Next Steps" >> $GITHUB_STEP_SUMMARY
-          echo "1. Build and push container images using the \`Build and push images\` workflow with tag \`${VERSION}\`" >> $GITHUB_STEP_SUMMARY
-          echo "2. Verify the artifacts at the staging directory" >> $GITHUB_STEP_SUMMARY
-          echo "3. Send [VOTE] email to dev@texera.apache.org" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Verification" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`bash" >> $GITHUB_STEP_SUMMARY
-          echo "# Import KEYS and verify signatures" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --import KEYS" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${SRC_TARBALL}.asc ${SRC_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${COMPOSE_TARBALL}.asc ${COMPOSE_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "# Verify SHA512 checksums" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${SRC_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${COMPOSE_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "**KEYS file:** https://downloads.apache.org/incubator/texera/KEYS" >> $GITHUB_STEP_SUMMARY
-
-          echo "✓ Release candidate workflow completed successfully!"
+          Staging directory: https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/

Review Comment:
   Done.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF

Review Comment:
   Done.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -262,9 +245,9 @@ jobs:
           COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
           IMAGE_REGISTRY="${{ steps.vars.outputs.image_registry }}"
 
-          # Get GPG key ID from the imported key
-          GPG_KEY_ID=$(gpg --list-secret-keys --keyid-format LONG | grep 'sec' | head -n1 | awk '{print $2}' | cut -d'/' -f2)
-          GPG_EMAIL=$(gpg --list-secret-keys | grep 'uid' | head -n1 | grep -oP '[\w\.-]+@[\w\.-]+')
+          # Artifacts are signed locally by the release manager, who fills these in.
+          GPG_KEY_ID="<FILL IN: signing key fingerprint>"

Review Comment:
   GPG_KEY_ID is meant to hold the fingerprint, so I left it as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8813:
URL: https://github.com/apache/texera/pull/8813#issuecomment-6519638517

   Backport PR opened: draft #9231 (https://github.com/apache/texera/pull/9231) to `release/v1.2`, assigned to @xuang7 — needs manual work because the cherry-pick conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #8813:
URL: https://github.com/apache/texera/pull/8813#issuecomment-6347333822

   > @xuang7 shall we move forward with this PR?
   
   I'll update the PR shortly. I've been a bit busy with schoolwork recently. Thanks for all the feedback!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4420146180


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Create and upload release candidate artifacts
+name: Create release candidate artifacts

Review Comment:
   I tested the workflow on my fork([run](https://github.com/xuang7/texera/actions/runs/40391860875)), and it works as expected: all build legs and create-rc passed, both checksums verify, and the fork has no GPG or SVN secrets. The test branch is this PR merged with main, with only the transitive license-version check relaxed since that day's resolved versions had drifted from LICENSE-binary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 closed pull request #8813: ci: stop signing and uploading release candidates in CI
URL: https://github.com/apache/texera/pull/8813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4365181914


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary

Review Comment:
   **Advisory:**
   
   This step replaces the `upload-rc` job, which was the only job with `needs: create-rc`. The seven `outputs:` that `create-rc` still declares (lines 56-63) are now read by nothing, and the workflow is `workflow_dispatch` only, so no caller can read them either. Steps in the same job read `steps.vars.outputs.*` directly. Please delete the `outputs:` block so the next editor does not go looking for a consumer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8813:
URL: https://github.com/apache/texera/pull/8813#issuecomment-6519371426

   Backport PR opened: #9230 (https://github.com/apache/texera/pull/9230) to `release/v1.3` — the cherry-pick was clean, so it is ready for review, waiting on @mengw15. It needs to be reopened once to start its checks; the PR says how.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #8813:
URL: https://github.com/apache/texera/pull/8813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8813:
URL: https://github.com/apache/texera/pull/8813#issuecomment-5944006044

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - No candidates found from `git blame` history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4277285983


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -262,9 +245,9 @@ jobs:
           COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
           IMAGE_REGISTRY="${{ steps.vars.outputs.image_registry }}"
 
-          # Get GPG key ID from the imported key
-          GPG_KEY_ID=$(gpg --list-secret-keys --keyid-format LONG | grep 'sec' | head -n1 | awk '{print $2}' | cut -d'/' -f2)
-          GPG_EMAIL=$(gpg --list-secret-keys | grep 'uid' | head -n1 | grep -oP '[\w\.-]+@[\w\.-]+')
+          # Artifacts are signed locally by the release manager, who fills these in.
+          GPG_KEY_ID="<FILL IN: signing key fingerprint>"

Review Comment:
   `GPG_KEY_ID` typically refers to a key ID (short/long), but the placeholder text asks for a fingerprint. This mismatch is likely to confuse (and may lead to inconsistent vote emails if the template expects one format). Consider either (a) renaming the variable to something like `GPG_FINGERPRINT`, or (b) adjusting the placeholder/comment to explicitly allow the expected format (e.g., 'long key id or fingerprint') to match what downstream template substitution expects.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          echo "✓ All artifacts downloaded successfully"
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}
+
+          # 3. Commit to dist/dev with your ASF account
+          cd ..
+          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera
+          if svn info https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR} >/dev/null 2>&1; then
+            svn update --set-depth=infinity svn-texera/${RC_DIR}
           else
-            # Directory doesn't exist remotely — create and add it
-            mkdir -p "$RC_DIR"
-            svn add "$RC_DIR"
-            echo "✓ Created new RC directory: $RC_DIR"
+            mkdir svn-texera/${RC_DIR} && svn add svn-texera/${RC_DIR}
           fi
+          cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/

Review Comment:
   The step summary asks release managers to copy/paste local commands, but these commands omit quoting around variables/paths. If artifact names ever include characters that the shell expands (or if paths include directories), the instructions can fail or behave unexpectedly. Recommend updating the summary commands to quote variable expansions (e.g., `\"${SRC_TARBALL}\"`, `\"rc/${SRC_TARBALL}\"*`, etc.) so the copy/paste workflow is robust.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          echo "✓ All artifacts downloaded successfully"
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}
+
+          # 3. Commit to dist/dev with your ASF account
+          cd ..
+          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera
+          if svn info https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR} >/dev/null 2>&1; then
+            svn update --set-depth=infinity svn-texera/${RC_DIR}
           else
-            # Directory doesn't exist remotely — create and add it
-            mkdir -p "$RC_DIR"
-            svn add "$RC_DIR"
-            echo "✓ Created new RC directory: $RC_DIR"
+            mkdir svn-texera/${RC_DIR} && svn add svn-texera/${RC_DIR}
           fi
+          cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/
+          svn add --force svn-texera/${RC_DIR}
+          svn commit svn-texera -m "Add Apache Texera ${VERSION} RC${RC_NUM} artifacts (source + docker-compose)"
+          \`\`\`
 
-      - name: Stage artifacts to SVN
-        run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          cd svn-texera/"$RC_DIR"
-
-          # Copy all artifacts
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            cp "$GITHUB_WORKSPACE/$artifact" .
-            cp "$GITHUB_WORKSPACE/${artifact}.asc" .
-            cp "$GITHUB_WORKSPACE/${artifact}.sha512" .
-          done
-
-          # Add files to SVN
-          svn add * --force
-
-          # Check status
-          svn status
-
-          echo "✓ Staged all artifacts to SVN"
-
-      - name: Commit artifacts to dist/dev
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          cd svn-texera
-
-          # Commit with descriptive message
-          svn commit -m "Add Apache Texera ${VERSION} RC${RC_NUM} artifacts (source + docker-compose)" \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          echo "✓ Committed artifacts to dist/dev/incubator/texera/$RC_DIR"
-
-      - name: Generate release summary
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          TAG_NAME="${{ needs.create-rc.outputs.tag_name }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-          COMMIT_HASH="${{ needs.create-rc.outputs.commit_hash }}"
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
-          echo "## Release Candidate Created Successfully!" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Release Information" >> $GITHUB_STEP_SUMMARY
-          echo "- **Version:** ${VERSION}" >> $GITHUB_STEP_SUMMARY
-          echo "- **RC Number:** RC${RC_NUM}" >> $GITHUB_STEP_SUMMARY
-          echo "- **Git Tag:** \`${TAG_NAME}\`" >> $GITHUB_STEP_SUMMARY
-          echo "- **Commit:** \`${COMMIT_HASH}\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Location" >> $GITHUB_STEP_SUMMARY
-          echo "**Staging Directory:** https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Created" >> $GITHUB_STEP_SUMMARY
-          echo "| Artifact | Description |" >> $GITHUB_STEP_SUMMARY
-          echo "|----------|-------------|" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${SRC_TARBALL}\` | Source code |" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${COMPOSE_TARBALL}\` | Docker Compose deployment bundle |" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "Each artifact has a corresponding \`.asc\` (GPG signature) and \`.sha512\` (checksum) file." >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Next Steps" >> $GITHUB_STEP_SUMMARY
-          echo "1. Build and push container images using the \`Build and push images\` workflow with tag \`${VERSION}\`" >> $GITHUB_STEP_SUMMARY
-          echo "2. Verify the artifacts at the staging directory" >> $GITHUB_STEP_SUMMARY
-          echo "3. Send [VOTE] email to dev@texera.apache.org" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Verification" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`bash" >> $GITHUB_STEP_SUMMARY
-          echo "# Import KEYS and verify signatures" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --import KEYS" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${SRC_TARBALL}.asc ${SRC_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${COMPOSE_TARBALL}.asc ${COMPOSE_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "# Verify SHA512 checksums" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${SRC_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${COMPOSE_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "**KEYS file:** https://downloads.apache.org/incubator/texera/KEYS" >> $GITHUB_STEP_SUMMARY
-
-          echo "✓ Release candidate workflow completed successfully!"
+          Staging directory: https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/

Review Comment:
   This line reads like the staging directory already contains artifacts, but after this PR the workflow no longer uploads anything to SVN. Suggest rewording to clarify this is the *target* directory to stage to *after* running the local SVN commands (e.g., 'Target staging directory (after commit): ...') to avoid confusion during release runs.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          echo "✓ All artifacts downloaded successfully"
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}

Review Comment:
   The step summary asks release managers to copy/paste local commands, but these commands omit quoting around variables/paths. If artifact names ever include characters that the shell expands (or if paths include directories), the instructions can fail or behave unexpectedly. Recommend updating the summary commands to quote variable expansions (e.g., `\"${SRC_TARBALL}\"`, `\"rc/${SRC_TARBALL}\"*`, etc.) so the copy/paste workflow is robust.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF

Review Comment:
   The redirection target should be quoted to avoid shell word-splitting/globbing issues and to match typical shell safety conventions. Prefer quoting `$GITHUB_STEP_SUMMARY` in redirects (e.g., `>> \"$GITHUB_STEP_SUMMARY\"`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4373367482


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary

Review Comment:
   Done in e64321fd3, removed the unused outputs block.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -226,28 +226,11 @@ jobs:
           ls -lh "$COMPOSE_TARBALL"
           echo "✓ Created Docker Compose bundle: $COMPOSE_TARBALL"
 
-      - name: Import GPG key

Review Comment:
   Agreed. I'll ask to have the four secrets removed from the repository settings once this merges.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,63 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "Verifying downloaded artifacts..."
-          ls -lh
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          echo "✓ All artifacts downloaded successfully"
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}

Review Comment:
   Quoted the paths and $GITHUB_STEP_SUMMARY, and reworded the staging line in e64321fd3. GPG_KEY_ID is meant to hold the fingerprint, so I left it as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4373439212


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Create and upload release candidate artifacts
+name: Create release candidate artifacts

Review Comment:
   Testing on my fork with a throwaway tag, I'll confirm here once it finishes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8813:
URL: https://github.com/apache/texera/pull/8813#issuecomment-5944022663

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8813?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 92.58%. Comparing base ([`98d3d4b`](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07b2bd6`](https://app.codecov.io/gh/apache/texera/commit/07b2bd6d21e5541bf6aba9ec92aaa6c7c5c2d6c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #8813   +/-   ##
   =========================================
     Coverage     92.58%   92.58%           
     Complexity     4963     4963           
   =========================================
     Files          1242     1242           
     Lines         52885    52885           
     Branches       6546     6546           
   =========================================
     Hits          48965    48965           
     Misses         2291     2291           
     Partials       1629     1629           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.05% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.41% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.55% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.56% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [98d3d4b](https://app.codecov.io/gh/apache/texera/commit/98d3d4b1ec8b02f611801d035c190fa31f56fa47?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8813?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4277203345


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -226,28 +226,11 @@ jobs:
           ls -lh "$COMPOSE_TARBALL"
           echo "✓ Created Docker Compose bundle: $COMPOSE_TARBALL"
 
-      - name: Import GPG key

Review Comment:
   With these gone, `GPG_PRIVATE_KEY`, `GPG_PASSPHRASE`, `SVN_USERNAME` and
   `SVN_PASSWORD` are referenced nowhere else in the repository — this workflow was
   their only consumer. Removing them from the repository settings is the other
   half of the change; leaving the key material and the ASF credentials in place
   keeps what the dev@ thread objected to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4163318614


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Create and upload release candidate artifacts
+name: Create release candidate artifacts

Review Comment:
   **Advisory:**
   
   A workflow change should ship with proof that the workflow actually dispatches: artifacts build and checksums verify, with no GPG or SVN use. The description says this will be run from this branch before merging, which is the right call; please link that test dispatch's run (or confirm it completes) before merging.



##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,59 @@ jobs:
           name: rc-artifacts
           path: |
             ${{ steps.vars.outputs.src_tarball }}
-            ${{ steps.vars.outputs.src_tarball }}.asc
             ${{ steps.vars.outputs.src_tarball }}.sha512
             ${{ steps.vars.outputs.compose_tarball }}
-            ${{ steps.vars.outputs.compose_tarball }}.asc
             ${{ steps.vars.outputs.compose_tarball }}.sha512
             vote-email.txt
           retention-days: 7
 
-  upload-rc:
-    runs-on: ubuntu-latest
-    needs: create-rc
-
-    steps:
-      - name: Download RC artifacts
-        uses: actions/download-artifact@v8
-        with:
-          name: rc-artifacts
-
-      - name: Verify downloaded artifacts
-        run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
-          echo "Verifying downloaded artifacts..."
-          ls -lh
-
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ ! -f "${artifact}.sha512" ]]; then
-              echo "Error: Missing artifact or signature/checksum for: $artifact"
-              exit 1
-            fi
-          done
-
-          echo "✓ All artifacts downloaded successfully"
-
-      - name: Install SVN
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y subversion
-          svn --version
-
-      - name: Checkout SVN dev directory
-        run: |
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          # Checkout the dev directory with depth=empty (lightweight)
-          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
-
-          cd svn-texera
-
-          # Check if RC directory already exists on the remote
-          SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera"
-          if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
-            # Directory exists remotely — update (checkout) it into the working copy
-            svn update --depth=infinity "$RC_DIR" \
-              --username "${{ secrets.SVN_USERNAME }}" \
-              --password "${{ secrets.SVN_PASSWORD }}" \
-              --no-auth-cache || true
-            # If update didn't bring it down (empty parent checkout), do a sparse checkout
-            if [[ ! -d "$RC_DIR" ]]; then
-              svn update --set-depth=infinity "$RC_DIR" \
-                --username "${{ secrets.SVN_USERNAME }}" \
-                --password "${{ secrets.SVN_PASSWORD }}" \
-                --no-auth-cache
-            fi
-            echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
-          else
-            # Directory doesn't exist remotely — create and add it
-            mkdir -p "$RC_DIR"
-            svn add "$RC_DIR"
-            echo "✓ Created new RC directory: $RC_DIR"
-          fi
-
-      - name: Stage artifacts to SVN
+      - name: Generate release summary
         run: |
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
-          cd svn-texera/"$RC_DIR"
-
-          # Copy all artifacts
-          for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
-            cp "$GITHUB_WORKSPACE/$artifact" .
-            cp "$GITHUB_WORKSPACE/${artifact}.asc" .
-            cp "$GITHUB_WORKSPACE/${artifact}.sha512" .
-          done
-
-          # Add files to SVN
-          svn add * --force
-
-          # Check status
-          svn status
+          VERSION="${{ steps.vars.outputs.version }}"
+          RC_NUM="${{ steps.vars.outputs.rc_num }}"
+          TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+          RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+          COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+          SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+          COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
 
-          echo "✓ Staged all artifacts to SVN"
+          cat >> $GITHUB_STEP_SUMMARY <<EOF
+          ## Release Candidate Artifacts Built
 
-      - name: Commit artifacts to dist/dev
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
+          - **Version:** ${VERSION}
+          - **RC Number:** RC${RC_NUM}
+          - **Git Tag:** \`${TAG_NAME}\`
+          - **Commit:** \`${COMMIT_HASH}\`
 
-          cd svn-texera
+          The artifacts are unsigned. Sign and stage them on your own machine:
 
-          # Commit with descriptive message
-          svn commit -m "Add Apache Texera ${VERSION} RC${RC_NUM} artifacts (source + docker-compose)" \
-            --username "${{ secrets.SVN_USERNAME }}" \
-            --password "${{ secrets.SVN_PASSWORD }}" \
-            --no-auth-cache
+          \`\`\`bash
+          # 1. Download and verify the checksums
+          gh run download ${{ github.run_id }} --repo ${{ github.repository }} -n rc-artifacts -D rc
+          cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
 
-          echo "✓ Committed artifacts to dist/dev/incubator/texera/$RC_DIR"
+          # 2. Sign with your own key
+          gpg --armor --detach-sign ${SRC_TARBALL}
+          gpg --armor --detach-sign ${COMPOSE_TARBALL}
 
-      - name: Generate release summary
-        run: |
-          VERSION="${{ needs.create-rc.outputs.version }}"
-          RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
-          TAG_NAME="${{ needs.create-rc.outputs.tag_name }}"
-          RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-          COMMIT_HASH="${{ needs.create-rc.outputs.commit_hash }}"
-          SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
-          COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
-          echo "## Release Candidate Created Successfully!" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Release Information" >> $GITHUB_STEP_SUMMARY
-          echo "- **Version:** ${VERSION}" >> $GITHUB_STEP_SUMMARY
-          echo "- **RC Number:** RC${RC_NUM}" >> $GITHUB_STEP_SUMMARY
-          echo "- **Git Tag:** \`${TAG_NAME}\`" >> $GITHUB_STEP_SUMMARY
-          echo "- **Commit:** \`${COMMIT_HASH}\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Location" >> $GITHUB_STEP_SUMMARY
-          echo "**Staging Directory:** https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Artifacts Created" >> $GITHUB_STEP_SUMMARY
-          echo "| Artifact | Description |" >> $GITHUB_STEP_SUMMARY
-          echo "|----------|-------------|" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${SRC_TARBALL}\` | Source code |" >> $GITHUB_STEP_SUMMARY
-          echo "| \`${COMPOSE_TARBALL}\` | Docker Compose deployment bundle |" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "Each artifact has a corresponding \`.asc\` (GPG signature) and \`.sha512\` (checksum) file." >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Next Steps" >> $GITHUB_STEP_SUMMARY
-          echo "1. Build and push container images using the \`Build and push images\` workflow with tag \`${VERSION}\`" >> $GITHUB_STEP_SUMMARY
-          echo "2. Verify the artifacts at the staging directory" >> $GITHUB_STEP_SUMMARY
-          echo "3. Send [VOTE] email to dev@texera.apache.org" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### Verification" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`bash" >> $GITHUB_STEP_SUMMARY
-          echo "# Import KEYS and verify signatures" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --import KEYS" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${SRC_TARBALL}.asc ${SRC_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "gpg --verify ${COMPOSE_TARBALL}.asc ${COMPOSE_TARBALL}" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "# Verify SHA512 checksums" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${SRC_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "sha512sum -c ${COMPOSE_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
-          echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "**KEYS file:** https://downloads.apache.org/incubator/texera/KEYS" >> $GITHUB_STEP_SUMMARY
+          # 3. Commit to dist/dev with your ASF account
+          cd ..
+          svn co --depth=empty https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera
+          mkdir svn-texera/${RC_DIR}
+          cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/
+          svn add svn-texera/${RC_DIR}

Review Comment:
   **Advisory:**
   
   This always creates and adds the RC directory, and the depth-empty checkout gives no hint when the directory already exists on the server. Re-cutting the same RC number (RC1 rebuilt after a bad first attempt) reaches `svn commit` with "already exists" and fails. The removed `upload-rc` job handled this exact case with an `svn info` check; carry that exists-check into the runbook.
   ```suggestion
             if svn info https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR} >/dev/null 2>&1; then
               # Re-cut of the same RC: pull the existing remote dir into the working copy.
               svn update --set-depth=infinity svn-texera/${RC_DIR}
             else
               mkdir svn-texera/${RC_DIR}
               svn add svn-texera/${RC_DIR}
             fi
             cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: stop signing and uploading release candidates in CI [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4394926672


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -226,28 +226,11 @@ jobs:
           ls -lh "$COMPOSE_TARBALL"
           echo "✓ Created Docker Compose bundle: $COMPOSE_TARBALL"
 
-      - name: Import GPG key

Review Comment:
   I deleted all four from the repository settings: `GPG_PRIVATE_KEY` and `GPG_PASSPHRASE` on Oct 1, `SVN_USERNAME` and `SVN_PASSWORD` today.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org