[jira] [Commented] (ZOOKEEPER-1784) Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290803#comment-14290803 ] 

Hadoop QA commented on ZOOKEEPER-1784:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12607443/ZOOKEEPER-1784.patch
  against trunk revision 1646992.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2487//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2487//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2487//console

This message is automatically generated.

> Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus
> ------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1784
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1784
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.1
>
>         Attachments: ZOOKEEPER-1784.patch, ZOOKEEPER-1784.patch
>
>
> If you look at Learner#syncWithLeader:
> {noformat}
>             while (self.isRunning()) {
>                 readPacket(qp);
>                 switch(qp.getType()) {
> .......
>                 case Leader.INFORM:
>                 case Leader.INFORMANDACTIVATE:
>                     PacketInFlight packet = new PacketInFlight();
>                     packet.hdr = new TxnHeader();
>                     if (qp.getType() == Leader.COMMITANDACTIVATE) {
> {noformat}
> I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read "qp.getType() == Leader.INFORMANDACTIVATE".
> Assigning to Alexander for now since this is part of ZOOKEEPER-107.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)