You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/07/10 13:55:19 UTC
[commons-net] branch release updated: Simplify expressions.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch release
in repository https://gitbox.apache.org/repos/asf/commons-net.git
The following commit(s) were added to refs/heads/release by this push:
new b4dd760 Simplify expressions.
b4dd760 is described below
commit b4dd7608df933c7772421e0c7d572cbc2fb1559b
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jul 10 09:55:16 2021 -0400
Simplify expressions.
Parse to primitive.
---
.../org/apache/commons/net/examples/telnet/TelnetClientExample.java | 2 +-
.../apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java | 4 ++--
src/main/java/org/apache/commons/net/telnet/Telnet.java | 2 +-
src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/examples/telnet/TelnetClientExample.java b/src/main/java/org/apache/commons/net/examples/telnet/TelnetClientExample.java
index 1cfa46b..804bf67 100644
--- a/src/main/java/org/apache/commons/net/examples/telnet/TelnetClientExample.java
+++ b/src/main/java/org/apache/commons/net/examples/telnet/TelnetClientExample.java
@@ -250,7 +250,7 @@ public class TelnetClientExample implements Runnable, TelnetNotificationHandler
end_loop = true;
}
}
- while(ret_read > 0 && end_loop == false);
+ while(ret_read > 0 && !end_loop);
try
{
diff --git a/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java b/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
index 7f2a3ab..d27ab9e 100644
--- a/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
+++ b/src/main/java/org/apache/commons/net/ftp/parser/VMSVersioningFTPEntryParser.java
@@ -135,10 +135,10 @@ public class VMSVersioningFTPEntryParser extends VMSFTPEntryParser
result = _preparse_matcher_.toMatchResult();
final String name = result.group(1);
final String version = result.group(2);
- final Integer nv = Integer.valueOf(version);
+ final int nv = Integer.parseInt(version);
final Integer existing = existingEntries.get(name);
if (null != existing) {
- if (nv.intValue() < existing.intValue()) {
+ if (nv < existing.intValue()) {
iter.remove(); // removes older version from original list.
}
}
diff --git a/src/main/java/org/apache/commons/net/telnet/Telnet.java b/src/main/java/org/apache/commons/net/telnet/Telnet.java
index b1d4e20..1b189cf 100644
--- a/src/main/java/org/apache/commons/net/telnet/Telnet.java
+++ b/src/main/java/org/apache/commons/net/telnet/Telnet.java
@@ -1069,7 +1069,7 @@ class Telnet extends SocketClient
_output_.flush();
}
aytMonitor.wait(timeout);
- if (aytFlag == false)
+ if (!aytFlag)
{
retValue = false;
aytFlag = true;
diff --git a/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java b/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
index 7fa3842..c614bdf 100644
--- a/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
+++ b/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
@@ -695,7 +695,7 @@ extends TestCase implements TelnetNotificationHandler
assertNotNull(tr);
final boolean res1 = ANSI.client.sendAYT(2000);
- if (res1 == true) {
+ if (res1) {
ayt_true_ok=true;
}
@@ -704,7 +704,7 @@ extends TestCase implements TelnetNotificationHandler
final boolean res2 = ANSI.client.sendAYT(2000);
- if (res2 == false) {
+ if (!res2) {
ayt_false_ok=true;
}