You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/08/03 05:38:08 UTC

[GitHub] [arrow] wgtmac commented on a diff in pull request #37003: GH-37002: [C++][Parquet] Add api to get RecordReader from RowGroupReader

wgtmac commented on code in PR #37003:
URL: https://github.com/apache/arrow/pull/37003#discussion_r1282665968


##########
cpp/src/parquet/file_reader.h:
##########
@@ -58,6 +59,11 @@ class PARQUET_EXPORT RowGroupReader {
   // column. Ownership is shared with the RowGroupReader.
   std::shared_ptr<ColumnReader> Column(int i);
 
+  // Construct a RecordReader for the indicated row group-relative column i.
+  // Ownership is shared with the RowGroupReader.
+  std::shared_ptr<internal::RecordReader> RecordReader(

Review Comment:
   I doubt tests checking exposure of internal namespace will complain about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org