You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/22 00:24:57 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #2479: [NETBEANS-4930] Upgrade Gradle Tooling 6.7 with JDK-15 Support
lkishalmi opened a new pull request #2479:
URL: https://github.com/apache/netbeans/pull/2479
Well, the final Gradle 6.7 just came before the branching of NetBeans 12.2. Though it seems fortunately it does not change the public API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2479: [NETBEANS-4930] Upgrade Gradle Tooling 6.7 with JDK-15 Support
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2479:
URL: https://github.com/apache/netbeans/pull/2479#discussion_r509917804
##########
File path: extide/libs.gradle/external/binaries-list
##########
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-74D642F331F4893E34F5063EE9A152D8C29D8323 gradle-tooling-api-6.6.jar
+566891D3FE72F69C9038A921BBE6CE255A77D4A1 gradle-tooling-api-6.7.jar
Review comment:
This change is fine, it is very likely compatible.
##########
File path: extide/gradle/external/binaries-list
##########
@@ -16,4 +16,4 @@
# under the License.
A271DEA739D4EBBD1A51F282AA130EB9314AD830 gradle-wrapper-4.10.2.jar
-2564503471E1FC18A4E7D2A120BC567EA3B26AA4 gradle-4.10.2-bin.zip
+E2E8BEBFCC5BA21D6FE9A27325D10EC1DB5D83FA gradle-6.7-bin.zip
Review comment:
Is this change really compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2479: [NETBEANS-4930] Upgrade Gradle Tooling 6.7 with JDK-15 Support
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2479:
URL: https://github.com/apache/netbeans/pull/2479#discussion_r509927222
##########
File path: extide/gradle/external/binaries-list
##########
@@ -16,4 +16,4 @@
# under the License.
A271DEA739D4EBBD1A51F282AA130EB9314AD830 gradle-wrapper-4.10.2.jar
-2564503471E1FC18A4E7D2A120BC567EA3B26AA4 gradle-4.10.2-bin.zip
+E2E8BEBFCC5BA21D6FE9A27325D10EC1DB5D83FA gradle-6.7-bin.zip
Review comment:
Well this one is just to compile the netbeans-gradle-tooling. It is needed to be able to debug the tooling jar inside NetBeans when using a modern JDK. The tooling jar still on Java 8 source (and with that target) level.
Basically this is just a compile-only dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2479: [NETBEANS-4930] Upgrade Gradle Tooling 6.7 with JDK-15 Support
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2479:
URL: https://github.com/apache/netbeans/pull/2479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists