You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/28 09:02:33 UTC

[GitHub] [pulsar] nodece commented on a diff in pull request #15348: [improve][broker] Make internalGetStats to async

nodece commented on code in PR #15348:
URL: https://github.com/apache/pulsar/pull/15348#discussion_r860655584


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1162,22 +1162,29 @@ private void internalGetSubscriptionsForNonPartitionedTopic(AsyncResponse asyncR
                 });
     }
 
-    protected TopicStats internalGetStats(boolean authoritative, boolean getPreciseBacklog,
-                                          boolean subscriptionBacklogSize, boolean getEarliestTimeInBacklog) {
+    protected void internalGetStatsAsync(AsyncResponse asyncResponse, boolean authoritative, boolean getPreciseBacklog,

Review Comment:
   @codelipenghui Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org