You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/05 09:35:01 UTC
[GitHub] [ozone] GlenGeng opened a new pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
GlenGeng opened a new pull request #1996:
URL: https://github.com/apache/ozone/pull/1996
## What changes were proposed in this pull request?
Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4912
## How was this patch tested?
CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1996:
URL: https://github.com/apache/ozone/pull/1996#issuecomment-793101399
Thanks @GlenGeng for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng closed pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
GlenGeng closed pull request #1996:
URL: https://github.com/apache/ozone/pull/1996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1996:
URL: https://github.com/apache/ozone/pull/1996#issuecomment-792552213
@GlenGeng , can u rename /Users/sbanerjee/github/hadoop-ozone/hadoop-ozone/dist/src/main/compose/upgrade/todo-test.sh to test.sh and see after enabling the upgrade tests, if all work fine.
cc @mukul1987 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng edited a comment on pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1996:
URL: https://github.com/apache/ozone/pull/1996#issuecomment-792598922
cc @bshashikant @mukul1987
I've manually did an upgrade test from latest master to last commit of this PR, the upgrade logic and allocating logic for delTxnId, containerId and localId works as expected.
- setup a cluster of latest master, use freon to write some data, manually remove some of the keys, manually close all the containers, use ldb of the debug tool to scan the containers cf and deletedBlocks cf to learn about the largest contaienrId and delTxnId..
- stop the cluster, but keep the data
- augment the PR to let `getNextId` to print a info trace `LOG.info("next id for {} is {}", sequenceIdName, batch.nextId);`.
- setup a cluster of this PR, use freon to write some data, manually remove some keys, checked from trace that, delTxnId, containerId and localId are correctly upgraded, and allocated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng edited a comment on pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1996:
URL: https://github.com/apache/ozone/pull/1996#issuecomment-792598922
cc @bshashikant @mukul1987
I've manually did an upgrade test from latest master to last commit of this PR, the upgrade logic for delTxnId, containerId and localId works as expected.
- setup a cluster of latest master, use freon to write some data, manually remove some of the keys, manually close all the containers, use ldb of the debug tool to scan the containers cf and deletedBlocks cf.
- stop the cluster, but keep the data
- augment the PR to let `getNextId` to print a info trace.
- setup a cluster of this PR, use freon to write some data, manually remove some keys, checked from trace that, delTxnId, containerId and localId are correctly upgraded, and allocated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1996:
URL: https://github.com/apache/ozone/pull/1996#issuecomment-791328249
@bshashikant @mukul1987 The upgrade PR for sequenceIdGen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng closed pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
GlenGeng closed pull request #1996:
URL: https://github.com/apache/ozone/pull/1996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1996:
URL: https://github.com/apache/ozone/pull/1996#issuecomment-792598922
@bshashikant @mukul1987 I've manually do a upgrade test from latest master to last commit of this PR, the upgrade logic for delTrxId, containerId and localId works as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant merged pull request #1996: HDDS-4912. Support inline upgrade from containerId, delTxnId, localId to SequenceIdGenerator.
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1996:
URL: https://github.com/apache/ozone/pull/1996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org