You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hari Sankar Sivarama Subramaniyan (JIRA)" <ji...@apache.org> on 2016/05/04 10:08:12 UTC

[jira] [Updated] (HIVE-12866) Allow ReduceSinkDeDuplication to kick in when there are constant keys

     [ https://issues.apache.org/jira/browse/HIVE-12866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hari Sankar Sivarama Subramaniyan updated HIVE-12866:
-----------------------------------------------------
    Assignee:     (was: Hari Sankar Sivarama Subramaniyan)

> Allow ReduceSinkDeDuplication to kick in when there are constant keys 
> ----------------------------------------------------------------------
>
>                 Key: HIVE-12866
>                 URL: https://issues.apache.org/jira/browse/HIVE-12866
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>
> Currently in ReduceSinkDeDuplication.checkExprs() we have the following check which prevents the optimization from kicking in as soon as we hit constant key. We should lift this restriction as much as possible.
> {code}
>     private Integer checkExprs(List<ExprNodeDesc> ckeys, List<ExprNodeDesc> pkeys,
>         ReduceSinkOperator cRS, ReduceSinkOperator pRS) throws SemanticException {
>       // If ckeys or pkeys have constant node expressions avoid the merge.
>       for (ExprNodeDesc ck : ckeys) {
>         if (ck instanceof ExprNodeConstantDesc) {
>           return null;
>         }
>       }
>       for (ExprNodeDesc pk : pkeys) {
>         if (pk instanceof ExprNodeConstantDesc) {
>           return null;
>         }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)