[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4796: feat: add prepareFirstToken api; update tr helper decode type

["warren830 (via GitHub)" <gi...@apache.org>]

warren830 commented on code in PR #4796:
URL: https://github.com/apache/incubator-devlake/pull/4796#discussion_r1150092166


##########
backend/helpers/pluginhelper/api/transformation_rule_helper.go:
##########
@@ -88,7 +90,7 @@ func (t TransformationRuleHelper[Tr]) Update(input *plugin.ApiResourceInput) (*p
 	if err != nil {
 		return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
 	}
-	err = errors.Convert(mapstructure.Decode(input.Body, &old))
+	err = DecodeMapStruct(input.Body, &old)

Review Comment:
   using this might cause some issues as `DecodeMapStruct` used ZeroFields 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org