You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Matthieu Baechler <mb...@linagora.com> on 2015/04/21 14:58:20 UTC
Pull-Request waiting for merge
Hi,
We have some Pull-Requests and Patches waiting to be applied or commented.
Here is the list :
https://github.com/apache/james-mailbox/pull/4
https://github.com/apache/james-mailbox/pull/5
https://github.com/apache/james-mailbox/pull/8
Could you please take care of theses PR ? It would allow us to submit
some others PRs that depends on it.
Thanks a lot,
--
Matthieu Baechler on behalf of Linagora James Team
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Eric Charles <er...@apache.org>.
I can point to the following (don't know the internals):
https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py
https://github.com/apache/mesos/blob/master/support/apply-review.sh
On 04/24/2015 05:53 AM, Matthieu Baechler wrote:
> Le 24/04/2015 11:24, Eric Charles a �crit :
>> Thx Matthieu, I have taken the patches and will test them.
> Great
>> Btw, If you are willing to contribute on the jira/github pr
>> integration, I can point you on apache projects having scripts to
>> achieve this.
> Of course we want to contribute on this integration, it would be very
> helpful to us.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Matthieu Baechler <mb...@linagora.com>.
Le 24/04/2015 11:24, Eric Charles a écrit :
> Thx Matthieu, I have taken the patches and will test them.
Great
> Btw, If you are willing to contribute on the jira/github pr
> integration, I can point you on apache projects having scripts to
> achieve this.
Of course we want to contribute on this integration, it would be very
helpful to us.
--
Matthieu Baechler
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Eric Charles <er...@apache.org>.
Thx Matthieu, I have taken the patches and will test them.
Btw, If you are willing to contribute on the jira/github pr integration,
I can point you on apache projects having scripts to achieve this.
On 04/24/2015 05:01 AM, Matthieu Baechler wrote:
> Ok, I misunderstood your position about github.
> You can find patches attached to tickets MAILBOX-221, MAILBOX-222 and
> MAILBOX-223.
>
> Let me know if anything goes wrong.
>
> Thanks,
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Eric Charles <er...@apache.org>.
MAILBOX-221 and MAILBOX-222 are committed, MAILBOX-223 not, see comments
in JIRA
On 04/24/2015 11:01 AM, Matthieu Baechler wrote:
> Ok, I misunderstood your position about github.
> You can find patches attached to tickets MAILBOX-221, MAILBOX-222 and
> MAILBOX-223.
>
> Let me know if anything goes wrong.
>
> Thanks,
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Matthieu Baechler <mb...@linagora.com>.
Ok, I misunderstood your position about github.
You can find patches attached to tickets MAILBOX-221, MAILBOX-222 and
MAILBOX-223.
Let me know if anything goes wrong.
Thanks,
--
Matthieu Baechler
Le 23/04/2015 19:19, Eric Charles a écrit :
> We don't use (yet) github pull requests.
> The best way is to attach the patches to the JIRA.
> When this is done, please communicate the ordered list of JIRA so we
> can review.
>
> Thx, Eric
>
> On 04/23/2015 08:57 AM, Matthieu Baechler wrote:
>> Hi,
>>
>> Actually, we use JIRA ticket names as our PR names so you can easily
>> find related work and github/apache integration works.
>> he
>> Here, https://github.com/apache/james-mailbox/pull/4 is MAILBOX-221,
>> https://github.com/apache/james-mailbox/pull/5 is MAILBOX-222 and
>> https://github.com/apache/james-mailbox/pull/8 is MAILBOX-223.
>>
>> We didn't submitted MAILBOX-211, Mailbox-217 , MAILBOX-220 and
>> MAILBOX-215 right now because they depends on the 3 tickets mentioned
>> bellow.
>>
>> Sending a patch or a PR for these tickets wouldn't work.
>>
>> We'll do as soon as these PR are merged.
>>
>> Cheers,
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Eric Charles <er...@apache.org>.
We don't use (yet) github pull requests.
The best way is to attach the patches to the JIRA.
When this is done, please communicate the ordered list of JIRA so we can
review.
Thx, Eric
On 04/23/2015 08:57 AM, Matthieu Baechler wrote:
> Hi,
>
> Actually, we use JIRA ticket names as our PR names so you can easily
> find related work and github/apache integration works.
> he
> Here, https://github.com/apache/james-mailbox/pull/4 is MAILBOX-221,
> https://github.com/apache/james-mailbox/pull/5 is MAILBOX-222 and
> https://github.com/apache/james-mailbox/pull/8 is MAILBOX-223.
>
> We didn't submitted MAILBOX-211, Mailbox-217 , MAILBOX-220 and
> MAILBOX-215 right now because they depends on the 3 tickets mentioned
> bellow.
>
> Sending a patch or a PR for these tickets wouldn't work.
>
> We'll do as soon as these PR are merged.
>
> Cheers,
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Matthieu Baechler <mb...@linagora.com>.
Hi,
Actually, we use JIRA ticket names as our PR names so you can easily
find related work and github/apache integration works.
Here, https://github.com/apache/james-mailbox/pull/4 is MAILBOX-221,
https://github.com/apache/james-mailbox/pull/5 is MAILBOX-222 and
https://github.com/apache/james-mailbox/pull/8 is MAILBOX-223.
We didn't submitted MAILBOX-211, Mailbox-217 , MAILBOX-220 and
MAILBOX-215 right now because they depends on the 3 tickets mentioned
bellow.
Sending a patch or a PR for these tickets wouldn't work.
We'll do as soon as these PR are merged.
Cheers,
--
Matthieu Baechler
Le 23/04/2015 12:23, Eric Charles a écrit :
> Is this in some way related to MAILBOX-211, Mailbox-217 , MAILBOX-220
> and MAILBOX-215 that Benoit mentioned in a previous mail ?
>
> If not, we still need patches in jira. Can you upload them?
>
>
> On 04/21/2015 08:58 AM, Matthieu Baechler wrote:
>> Hi,
>>
>> We have some Pull-Requests and Patches waiting to be applied or
>> commented.
>>
>> Here is the list :
>>
>> https://github.com/apache/james-mailbox/pull/4
>> https://github.com/apache/james-mailbox/pull/5
>> https://github.com/apache/james-mailbox/pull/8
>>
>> Could you please take care of theses PR ? It would allow us to submit
>> some others PRs that depends on it.
>>
>> Thanks a lot,
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Pull-Request waiting for merge
Posted by Eric Charles <er...@apache.org>.
Is this in some way related to MAILBOX-211, Mailbox-217 , MAILBOX-220
and MAILBOX-215 that Benoit mentioned in a previous mail ?
If not, we still need patches in jira. Can you upload them?
On 04/21/2015 08:58 AM, Matthieu Baechler wrote:
> Hi,
>
> We have some Pull-Requests and Patches waiting to be applied or
> commented.
>
> Here is the list :
>
> https://github.com/apache/james-mailbox/pull/4
> https://github.com/apache/james-mailbox/pull/5
> https://github.com/apache/james-mailbox/pull/8
>
> Could you please take care of theses PR ? It would allow us to submit
> some others PRs that depends on it.
>
> Thanks a lot,
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org