You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@asterixdb.apache.org by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org> on 2018/08/01 18:37:43 UTC

Change in asterixdb[master]: [NO ISSUE] Set logging level to WARN in MaterializingPipelin...

abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2832

Change subject: [NO ISSUE] Set logging level to WARN in MaterializingPipelinedPartition
......................................................................

[NO ISSUE] Set logging level to WARN in MaterializingPipelinedPartition

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Failures in MaterializingPipelinedPartition can be due to many reasons
such as a job cancellation. WARN log level seems to be adequate for
such failures keeping ERROR for more critical failures.

Change-Id: I45f475afae114dc71d2d89d9deaab7f3b3c5a0b8
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/2832/1

diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java
index 29c2ff2..37f33a9 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java
@@ -89,7 +89,7 @@
                 Thread thread = Thread.currentThread();
                 setDataConsumerThread(thread); // Sets the data consumer thread to the current thread.
                 try {
-                    thread.setName(MaterializingPipelinedPartition.class.getName() + pid);
+                    thread.setName(MaterializingPipelinedPartition.class.getName() + " " + pid);
                     FileReference fRefCopy;
                     synchronized (MaterializingPipelinedPartition.this) {
                         while (fRef == null && !eos && !failed) {
@@ -164,7 +164,7 @@
                         }
                     }
                 } catch (Exception e) {
-                    LOGGER.log(Level.ERROR, e.getMessage(), e);
+                    LOGGER.warn("Failure writing to a frame", e);
                 } finally {
                     setDataConsumerThread(null); // Sets back the data consumer thread to null.
                 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2832
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45f475afae114dc71d2d89d9deaab7f3b3c5a0b8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>