[jira] [Commented] (HADOOP-11859) PseudoAuthenticationHandler fails with httpcomponents v4.4

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505993#comment-14505993 ] 

Hadoop QA commented on HADOOP-11859:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 26s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | javac |   7m 25s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 31s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   5m 26s | There were no new checkstyle issues. |
| {color:green}+1{color} | install |   1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   0m 36s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |   5m 18s | Tests passed in hadoop-auth. |
| | |  45m 11s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12727011/HADOOP-11859.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 2c14690 |
| hadoop-auth test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6143/artifact/patchprocess/testrun_hadoop-auth.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6143/testReport/ |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6143//console |


This message was automatically generated.

> PseudoAuthenticationHandler fails with httpcomponents v4.4
> ----------------------------------------------------------
>
>                 Key: HADOOP-11859
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11859
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HADOOP-11859.patch
>
>
> This shows in the context of WebHCat and Hive (which recently moved to httpcomponents:httpclient:4.4) but could happen in other places.
> URLEncodedUtils.parse(String, Charset) which is called from PseudoAuthenticationHandler.getUserName() with the 1st argument produced by HttpServletRequest.getQueryString().
> The later returns NULL if there is no query string in the URL.
> in httpcoponents:httpclient:4.2.5 parse() gracefully handles first argument being NULL, but in 4.4 it NPEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)