[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #10824: [Fix] (array-type) add the supported sub-type and regression

[GitBox <gi...@apache.org>]

carlvinhust2012 commented on code in PR #10824:
URL: https://github.com/apache/doris/pull/10824#discussion_r924170074


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/TypeDef.java:
##########
@@ -118,8 +118,11 @@ private void analyzeNestedType(ScalarType type) throws AnalysisException {
             throw new AnalysisException("Unsupported data type: " + type.toSql());
         }
         if (!type.getPrimitiveType().isIntegerType()
-                && !type.getPrimitiveType().isCharFamily()) {
-            throw new AnalysisException("Array column just support INT/VARCHAR sub-type");
+                && !type.getPrimitiveType().isCharFamily()

Review Comment:
   The return type of 'Type.getArraySubTypes() ' is ArrayList<Type>. 
   But here the 'type' is the sub-type of array, I think no need use 'getArraySubTypes()' again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org