You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by gr...@apache.org on 2021/12/16 00:06:36 UTC
[royale-asjs] branch develop updated (3a3fa6b -> ecbcdc6)
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.
from 3a3fa6b Tidy up in Panel. Fixes #1169
new 936c797 Fix for attempts to measure things like CheckBox to early (which causes infinite recursion because of non-mx internal implementation)
new 4a57a2a potential fix for Panel issue in js tests.
new ecbcdc6 fix - Viewstack does not display the first child when starting up
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
frameworks/projects/MXRoyale/src/main/royale/mx/containers/Panel.as | 3 ++-
.../projects/MXRoyale/src/main/royale/mx/containers/ViewStack.as | 2 +-
frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as | 4 ++--
3 files changed, 5 insertions(+), 4 deletions(-)
[royale-asjs] 01/03: Fix for attempts to measure things like CheckBox to early (which causes infinite recursion because of non-mx internal implementation)
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 936c797345eea16431d87eedd0829b83f284a51d
Author: greg-dove <gr...@gmail.com>
AuthorDate: Thu Dec 16 13:04:10 2021 +1300
Fix for attempts to measure things like CheckBox to early (which causes infinite recursion because of non-mx internal implementation)
---
frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
index 1be23ea..857004e 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
@@ -2686,7 +2686,7 @@ COMPILE::JS
if (oldWidth.length)
this.positioner.style.width = "";
var mw:Number = this.positioner.offsetWidth;
- if (mw == 0 && numChildren > 0)
+ if (mw == 0 && _initialized && numChildren > 0)
{
// if children are aboslute positioned, offsetWidth can be 0 in Safari
for (var i:int = 0; i < numChildren; i++)
@@ -2763,7 +2763,7 @@ COMPILE::JS
if (oldHeight.length)
this.positioner.style.height = "";
var mh:Number = this.positioner.offsetHeight;
- if (mh == 0 && numChildren > 0)
+ if (mh == 0 && _initialized && numChildren > 0)
{
for (var i:int = 0; i < numChildren; i++)
{
[royale-asjs] 03/03: fix - Viewstack does not display the first child when starting up
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit ecbcdc6e60b4d009a704db0c2f089d0e44355229
Author: greg-dove <gr...@gmail.com>
AuthorDate: Thu Dec 16 13:06:23 2021 +1300
fix - Viewstack does not display the first child when starting up
---
frameworks/projects/MXRoyale/src/main/royale/mx/containers/ViewStack.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/ViewStack.as b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/ViewStack.as
index de038dd..1a3ba4e 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/ViewStack.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/ViewStack.as
@@ -971,7 +971,7 @@ public class ViewStack extends Container implements /*IHistoryManagerClient,*/ I
var top:Number = contentY;
// Stretch the selectedIndex to fill our size
- if (selectedIndex != -1)
+ if (nChildren && selectedIndex != -1)
{
var child:UIComponent =
UIComponent(getChildAt(selectedIndex));
[royale-asjs] 02/03: potential fix for Panel issue in js tests.
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 4a57a2a038f92cbb5161108764be2a1009dfe5db
Author: greg-dove <gr...@gmail.com>
AuthorDate: Thu Dec 16 13:05:29 2021 +1300
potential fix for Panel issue in js tests.
---
frameworks/projects/MXRoyale/src/main/royale/mx/containers/Panel.as | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/Panel.as b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/Panel.as
index 1511b47..75803d2 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/Panel.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/Panel.as
@@ -821,7 +821,8 @@ public class Panel extends Container
var panelView:PanelView = view as PanelView;
if (panelView.contentArea == this)
return super.numElements;
- return panelView.contentArea.numElements;
+ //likewise, contentArea may not be available yet during early phases, use null safety:
+ return panelView.contentArea ? panelView.contentArea.numElements : 0;
}
/**