You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/22 10:06:28 UTC

[GitHub] [incubator-kyuubi] zhaomin1423 commented on a diff in pull request #3289: Filter Spark event logger outside the spark engine

zhaomin1423 commented on code in PR #3289:
URL: https://github.com/apache/incubator-kyuubi/pull/3289#discussion_r951253018


##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/HiveSQLEngine.scala:
##########
@@ -66,7 +65,6 @@ object HiveSQLEngine extends Logging {
   var currentEngine: Option[HiveSQLEngine] = None
   val hiveConf = new HiveConf()
   val kyuubiConf = new KyuubiConf()
-  kyuubiConf.set(ENGINE_EVENT_LOGGERS.key, "JSON")

Review Comment:
   > one option maybe, we can add engine event loggers config for each engine.
   > e.g.
   > ```
   > kyuubi.engine.spark.event.loggers
   > kyuubi.engine.jdbc.event.loggers
   > ...
   > ```
   
   good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org