You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/01 03:35:39 UTC

[GitHub] zeppelin pull request #2083: [HOT FIX][gh-pages] Fix 'Error: ng:areq Bad Arg...

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2083

    [HOT FIX][gh-pages] Fix 'Error: ng:areq Bad Argument' in Helium page

    ### What is this PR for?
    After #1980 merged, below error comes out in http://zeppelin.apache.org/helium_packages.html.
    <img width="1045" alt="screen shot 2017-03-01 at 12 30 18 pm" src="https://cloud.githubusercontent.com/assets/10060731/23444845/dd33a006-fe7a-11e6-9324-0c737830c7b0.png">
    
    I referred [this stackoverflow](http://stackoverflow.com/questions/25895235/angularjs-error-ngareq-argument-homecontroller-is-not-a-function-got-und) question to fix this. 
    
    
    ### What type of PR is it?
    Bug Fix & Hot Fix
    
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    1. Run `gh-pages` locally as described in [gh-pages#run-website](https://github.com/apache/zeppelin/tree/gh-pages#run-website).
    2. Go to Helium menu and check the page is properly shown or not
    
    ### Screenshots (if appropriate)
     - Before 
    <img width="1045" alt="screen shot 2017-03-01 at 12 30 18 pm" src="https://cloud.githubusercontent.com/assets/10060731/23444936/66f290f4-fe7b-11e6-9867-023e2086c5f0.png">
    
     - After 
    <img width="961" alt="screen shot 2017-03-01 at 12 34 38 pm" src="https://cloud.githubusercontent.com/assets/10060731/23444943/7b911cce-fe7b-11e6-9a41-93d312437341.png">
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin hotfix/heliumPageError

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2083.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2083
    
----
commit 3fec5220b3d2952e6d23901aeed11e635c44ddd5
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-03-01T03:28:03Z

    Fix 'Error: ng:areq Bad Argument' in Helium page

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2083: [HOT FIX][gh-pages] Fix 'Error: ng:areq Bad Argument' ...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2083
  
    Merging into `gh-pages` as hotfix if there are no more comments on this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2083: [HOT FIX][gh-pages] Fix 'Error: ng:areq Bad Arg...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2083


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---