You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/04/11 02:18:12 UTC
Review Request 58332: In the non English environment, the login fails,
the browser returns garbled,
we need to log in to support the internationalization of the function to
solve this problem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1508
https://issues.apache.org/jira/browse/RANGER-1508
Repository: ranger
Description
-------
Use the browser to log in Chinese Ranger admin operating system, when an error occurs, garbage is returned to the browser, the server code logic, and found English error information using hard encoding compared and caused the program logic error. So we need to log in to support the internationalization of the function to solve such problems.
The reason is because the location error (Locale.getDefault); different countries and regions to obtain the local languages, we need according to the login user login area language encoding in different countries and regions of the dynamic of the current user. According to the configuration file to dynamically access the correct language.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
Diff: https://reviews.apache.org/r/58332/diff/1/
Testing
-------
tested it
Thanks,
pengjianhua
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/#review172295
-----------------------------------------------------------
Ship it!
It looks good. The function is right through tested and verified.
- Qiang Zhang
On \u56db\u6708 17, 2017, 5:30 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58332/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 17, 2017, 5:30 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1508
> https://issues.apache.org/jira/browse/RANGER-1508
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
> security-admin/src/main/java/org/apache/ranger/util/CLIUtil.java 0fd0e70
> security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
> security-admin/src/main/webapp/META-INF/applicationContext.xml 95d462b
>
>
> Diff: https://reviews.apache.org/r/58332/diff/2/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/
-----------------------------------------------------------
(Updated \u56db\u6708 17, 2017, 5:30 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Changes
-------
Use spring to manage internationalization
Bugs: RANGER-1508
https://issues.apache.org/jira/browse/RANGER-1508
Repository: ranger
Description
-------
Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
security-admin/src/main/java/org/apache/ranger/util/CLIUtil.java 0fd0e70
security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
security-admin/src/main/webapp/META-INF/applicationContext.xml 95d462b
Diff: https://reviews.apache.org/r/58332/diff/2/
Changes: https://reviews.apache.org/r/58332/diff/1-2/
Testing
-------
tested it
Thanks,
pengjianhua
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/#review171550
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On \u56db\u6708 11, 2017, 7:34 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58332/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 11, 2017, 7:34 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1508
> https://issues.apache.org/jira/browse/RANGER-1508
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
> security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58332/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On \u56db\u6708 13, 2017, 5:50 a.m., Gautam Borad wrote:
> > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
> > Lines 154 (patched)
> > <https://reviews.apache.org/r/58332/diff/1/?file=1687769#file1687769line155>
> >
> > Ideally, we should fallback to default (en_US) locale, in case the file is not found.
Hi Thank you for your advice. I used Locale.getDefault() to get the current system environment language.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/#review171843
-----------------------------------------------------------
On \u56db\u6708 11, 2017, 7:34 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58332/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 11, 2017, 7:34 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1508
> https://issues.apache.org/jira/browse/RANGER-1508
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
> security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58332/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/#review171843
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
Lines 154 (patched)
<https://reviews.apache.org/r/58332/#comment244860>
Ideally, we should fallback to default (en_US) locale, in case the file is not found.
- Gautam Borad
On April 11, 2017, 7:34 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58332/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 7:34 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1508
> https://issues.apache.org/jira/browse/RANGER-1508
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
> security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58332/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On \u56db\u6708 11, 2017, 11:09 a.m., Zsombor Gegesy wrote:
> > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
> > Line 48 (original), 58 (patched)
> > <https://reviews.apache.org/r/58332/diff/1/?file=1687769#file1687769line58>
> >
> > It's not a good practice to use static fields, and initialize it from instance method.
Hi, Gegesy .Thank you for your advice , Use spring to manage internationalization ,If you have time, please review again.
> On \u56db\u6708 11, 2017, 11:09 a.m., Zsombor Gegesy wrote:
> > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
> > Lines 144 (patched)
> > <https://reviews.apache.org/r/58332/diff/1/?file=1687769#file1687769line145>
> >
> > Instead of converting a resource to a file path, and reading from that, why don't you directly get with getClass().getResourceAsStream(...) ?
> > Or even better, why not use springs excellent Properties loading support?
Hi, Thank you for your advice ,spring is better , So I use spring to manage internationalization ,If you have time, please review again.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/#review171552
-----------------------------------------------------------
On \u56db\u6708 11, 2017, 7:34 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58332/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 11, 2017, 7:34 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1508
> https://issues.apache.org/jira/browse/RANGER-1508
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
> security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58332/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/#review171552
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
Line 48 (original), 58 (patched)
<https://reviews.apache.org/r/58332/#comment244499>
It's not a good practice to use static fields, and initialize it from instance method.
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
Lines 144 (patched)
<https://reviews.apache.org/r/58332/#comment244500>
Instead of converting a resource to a file path, and reading from that, why don't you directly get with getClass().getResourceAsStream(...) ?
Or even better, why not use springs excellent Properties loading support?
- Zsombor Gegesy
On April 11, 2017, 7:34 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58332/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 7:34 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1508
> https://issues.apache.org/jira/browse/RANGER-1508
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
> security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
> security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58332/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 58332: The browser returns garbled when we login
ranger security admin in non-English environment. We need support the
internationalization function to solve this problem
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58332/
-----------------------------------------------------------
(Updated \u56db\u6708 11, 2017, 7:34 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Summary (updated)
-----------------
The browser returns garbled when we login ranger security admin in non-English environment. We need support the internationalization function to solve this problem
Bugs: RANGER-1508
https://issues.apache.org/jira/browse/RANGER-1508
Repository: ranger
Description (updated)
-------
Use the browser to log in Ranger admin in Chinese operation system. The browser returns garbled when an error occurs. The error reason is that the Ranger admin used hard code to compare error information between Chinese character and English character. So we need support the internationalization function to solve this problem.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 580b6bc
security-admin/src/main/resources/internationalization/messages.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_cs_CZ.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_de.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_es_ES.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_fr.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_it.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_ko_KR.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_lt.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pl.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pt_BR.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_pt_PT.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_uk_UA.properties PRE-CREATION
security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION
Diff: https://reviews.apache.org/r/58332/diff/1/
Testing
-------
tested it
Thanks,
pengjianhua