You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by eb...@apache.org on 2020/12/04 13:15:47 UTC
[commons-dbcp] 02/09: Replace StringBuffer with StringBuilder
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
commit ec6321c7b73c81dc24293710931dc6ce7c3220a4
Author: Emmanuel Bourg <eb...@apache.org>
AuthorDate: Fri Dec 4 13:31:15 2020 +0100
Replace StringBuffer with StringBuilder
---
src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java | 2 +-
src/main/java/org/apache/commons/dbcp2/PStmtKey.java | 2 +-
src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java | 2 +-
src/test/java/org/apache/commons/dbcp2/StackMessageLog.java | 2 +-
.../org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java b/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java
index 2075be3..bdceb41 100644
--- a/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java
@@ -98,7 +98,7 @@ public class DelegatingConnection<C extends Connection> extends AbandonedTrace i
if (conn.isClosed()) {
str = "connection is closed";
} else {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
sb.append(hashCode());
final DatabaseMetaData meta = conn.getMetaData();
if (meta != null) {
diff --git a/src/main/java/org/apache/commons/dbcp2/PStmtKey.java b/src/main/java/org/apache/commons/dbcp2/PStmtKey.java
index 9a39557..b6aea70 100644
--- a/src/main/java/org/apache/commons/dbcp2/PStmtKey.java
+++ b/src/main/java/org/apache/commons/dbcp2/PStmtKey.java
@@ -934,7 +934,7 @@ public class PStmtKey {
@Override
public String toString() {
- final StringBuffer buf = new StringBuffer();
+ final StringBuilder buf = new StringBuilder();
buf.append("PStmtKey: sql=");
buf.append(sql);
buf.append(", catalog=");
diff --git a/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java b/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java
index 441e24c..4f9bc4f 100644
--- a/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java
+++ b/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java
@@ -62,7 +62,7 @@ class PoolKey implements Serializable {
@Override
public String toString() {
- final StringBuffer sb = new StringBuffer(50);
+ final StringBuilder sb = new StringBuilder(50);
sb.append("PoolKey(");
sb.append("UserName").append(", ").append(dataSourceName);
sb.append(')');
diff --git a/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java b/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
index b450de2..f2a3e67 100644
--- a/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
+++ b/src/test/java/org/apache/commons/dbcp2/StackMessageLog.java
@@ -48,7 +48,7 @@ public class StackMessageLog extends SimpleLog {
protected void log(final int type, final Object message, final Throwable t) {
lock.lock();
try {
- final StringBuffer buf = new StringBuffer();
+ final StringBuilder buf = new StringBuilder();
buf.append(message.toString());
if(t != null) {
buf.append(" <");
diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java b/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java
index 248efcb..2cdd0bf 100644
--- a/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java
+++ b/src/test/java/org/apache/commons/dbcp2/managed/TestConnectionWithNarayana.java
@@ -47,7 +47,7 @@ public class TestConnectionWithNarayana {
private static final String DROP_STMT = "DROP TABLE TEST_DATA";
static {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
sb.append("Start");
sb.append("payload");
for (int i = 0; i < 10000; i++) {