You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "jfclere (via GitHub)" <gi...@apache.org> on 2023/08/08 15:15:52 UTC
[GitHub] [tomcat] jfclere opened a new pull request, #644: Warn when non default ciphers are removed because the engine rejects them.
jfclere opened a new pull request, #644:
URL: https://github.com/apache/tomcat/pull/644
When using nmap --script ssl-enum-ciphers -p port host
the ciphers proposed are often a small subset of the expect ones.
A warning helps to see what is rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #644: Warn when non default ciphers are removed because the engine rejects them.
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #644:
URL: https://github.com/apache/tomcat/pull/644#issuecomment-1669965294
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] jfclere merged pull request #644: Warn when non default ciphers are removed because the engine rejects them.
Posted by "jfclere (via GitHub)" <gi...@apache.org>.
jfclere merged PR #644:
URL: https://github.com/apache/tomcat/pull/644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on a diff in pull request #644: Warn when non default ciphers are removed because the engine rejects them.
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on code in PR #644:
URL: https://github.com/apache/tomcat/pull/644#discussion_r1287317502
##########
java/org/apache/tomcat/util/net/SSLUtilBase.java:
##########
@@ -122,6 +122,10 @@ protected SSLUtilBase(SSLHostConfigCertificate certificate, boolean warnTls13) {
sslHostConfig.setTls13RenegotiationAvailable(isTls13RenegAuthAvailable());
// Calculate the enabled ciphers
+ boolean warnOnSkip = true;
+ if (sslHostConfig.getCiphers().equals(sslHostConfig.DEFAULT_TLS_CIPHERS)) {
+ warnOnSkip = false;
+ }
Review Comment:
`boolean warnOnSkip = !sslHostConfig.getCiphers().equals(sslHostConfig.DEFAULT_TLS_CIPHERS);`
And move this inside the block where it is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org