Re: Review Request 14239: OOZIE-1504 parameterize coord EL functions.

[Rohini Palaniswamy <ro...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14239/#review29751
-----------------------------------------------------------



http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java
<https://reviews.apache.org/r/14239/#comment57221>

    Only the test case has been changed. You need to fix the logic. The expected instances is still not right even with this. There should have been 3 instances for this case. 
    
    Please have tests for 3 cases of nominal time - same as absolute instance, > absolute instance, < absolute instance . Keep the coord job start time earlier than the dataset initial instance, so that you can do the < start instance case.  We also need to throw an exception if the absolute time is < dataset initial instance. 


- Rohini Palaniswamy


On Nov. 28, 2013, 12:28 a.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14239/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 12:28 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1504
>     https://issues.apache.org/jira/browse/OOZIE-1504
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> Use-case 
> -----------------------------
> A workflow that processes input datasets for the past 30 days:
> <input-events>
> <data-in name="event_input_path_format1" dataset="EVENT_INPUT_FORMAT1">
> <start-instance>$
> {coord:current(-30)}
> </start-instance>
> <end-instance>$
> {coord:current(-1)}
> </end-instance>
> </data-in>
> <data-in name="event_input_path_format2" dataset="EVENT_INPUT_FORMAT2">
> <start-instance>$
> {coord:current(-30)}
> </start-instance>
> <end-instance>$
> {coord:current(-1)}
> </end-instance>
> </data-in>
> </input-events>
> Instead, one wants it to start on the same specific date so that each day, it
> processes one more data set than the last day (the datasets are daily). Something like the following is not supported
> <input-events>
> <data-in name="event_input_path_format1" dataset="EVENT_INPUT_FORMAT1">
> <start-instance>${coord:absolute(2013-03-15T00:00Z)}</start-instance>
> <end-instance>$
> {coord:current(-1)}
> </end-instance>
> </data-in>
> <data-in name="event_input_path_format2" dataset="EVENT_INPUT_FORMAT2">
> <start-instance>${coord:absolute(2013-03-15T00:00Z)}</start-instance>
> <end-instance>$
> {coord:current(-1)}
> </end-instance>
> </data-in>
> </input-events>
> ---------------------------------
> 
> 
> Fix support providing absolute value for instance range. One can have a combination of absolute date with coord:current().
> Other EL function are not supported with absolute date.
> 
> coord:Current() can be parameterize. 
> 
> like 
>    <end-instance>${coord:latest(end_date)}</end-instance> // where end_date is one of the specified property.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1544636 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1544636 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-default.xml 1544636 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 1544636 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1544636 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/coord-dataset-absolute.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1544636 
>   http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki 1544636 
> 
> Diff: https://reviews.apache.org/r/14239/diff/
> 
> 
> Testing
> -------
> 
> Added multiple test cases to verify combination of scenarios.
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>