You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "gesterzhou (GitHub)" <gi...@apache.org> on 2018/12/27 23:25:07 UTC
[GitHub] [geode] gesterzhou opened pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
…processedEvents.
@jhuynh1 @boglesby
When ConcurrentCacheModificationException happened, GatewaySenderEventImpl
should save the status and notify gatewaysender if it hold primary queue,
because other member might have put the event into the secondary queue
Let event with CME only enqueue to primary, but not to dispatch. The old
logic does not allow CME event to enqueue. This is wrong, because an event
without CME might have been added into the secondary queue.
We should not dispatch the CME event, otherwise it will cause remote site
data inconsistency since these CME events are misordered.
So we should enqueue it, but not to dispatch.
Also add rollingUpgradeTests
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
This block of two ifs is already within a try > if > try > else.
For longterm readability of this function, can you refactor this else into it's own function?
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Can this be broken up until 6 smaller functions to make this overall function easier to read given it's already over 100 lines.
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Same with `oldEventShouldBeProcessedAtTwoNewSender`. Maybe a few helper functions can be created that can be used in both `oldEventShouldBeProcessedAtTwoNewSender` and `oldEventShouldBeProcessedAtNewSender`
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] gesterzhou commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "gesterzhou (GitHub)" <gi...@apache.org>.
this is old comments, I did not remove it
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
I realize that these are test cases so maybe you can ignore this request.
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] gesterzhou closed pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "gesterzhou (GitHub)" <gi...@apache.org>.
[ pull request closed by gesterzhou ]
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Perhaps the two halves of the OR can be pulled into their own boolean variables for better readability?
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] gesterzhou commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "gesterzhou (GitHub)" <gi...@apache.org>.
This part of fix will resolve the root cause which caused the revert.
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
What does this comment mean?
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3044: GEODE-3967: fix the offheap memory leak in serial gateway sender's un…
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
I like your comment for this function. I shows the 4 distinct steps of this method.
Maybe each step can be pulled out into it's own function since this function is already over 100 lines. It might help with readability
[ Full content available at: https://github.com/apache/geode/pull/3044 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org