[GitHub] rafaelweingartner commented on a change in pull request #2290: WIP: add track id to async api calls

[gi...@git.apache.org]

rafaelweingartner commented on a change in pull request #2290: WIP: add track id to async api calls
URL: https://github.com/apache/cloudstack/pull/2290#discussion_r143740407
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##########
 @@ -333,6 +333,7 @@ public boolean getStartVm() {
                     } catch (NumberFormatException e) {
                         throw new InvalidParameterValueException("Unable to translate and find entity with networkId: " + ips.get("networkid"));
                     }
+                    // so no network found but a valid number as network id; are we assuming exceptions thrown or lucky guessing?
 
 Review comment:
   @DaanHoogland so you are the one that makes the enlightened comments all around ACS code base?! ahahaha
   
   If the network ID is invalid (it was not found), it means that something else further down the deployment process will break, right? If this is the case, I think we could stop the processing here and throw a runtime exception.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services