You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "gwik (via GitHub)" <gi...@apache.org> on 2024/10/22 09:54:07 UTC

[PR] Fix arrow-json writer empty [arrow-rs]

gwik opened a new pull request, #6614:
URL: https://github.com/apache/arrow-rs/pull/6614

   The Writer output with the ArrayJson formatter was empty when no record were in the output (no write or empty batch write). It should output an empty JSON array `[]` instead.
   
   Closes #6613
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arrow-json writer empty [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #6614:
URL: https://github.com/apache/arrow-rs/pull/6614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arrow-json writer empty [arrow-rs]

Posted by "jackkleeman (via GitHub)" <gi...@apache.org>.
jackkleeman commented on PR #6614:
URL: https://github.com/apache/arrow-rs/pull/6614#issuecomment-2538577586

   Hey folks, I'm not sure if this should have gone out as a minor release, as it will break anyone who assumes that there is no output if there were no rows. We were working around the lack of output by adding the [] ourselves. Super glad we don't have to do that any more, but sadly Cargo automatically bumped the minor version and now we see `[][]` :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arrow-json writer empty [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6614:
URL: https://github.com/apache/arrow-rs/pull/6614#issuecomment-2538585646

   Apologies that this broke your workflow, I viewed this a bug fix and therefore it was appropriate to roll out in a non-breaking release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arrow-json writer empty [arrow-rs]

Posted by "jackkleeman (via GitHub)" <gi...@apache.org>.
jackkleeman commented on PR #6614:
URL: https://github.com/apache/arrow-rs/pull/6614#issuecomment-2538593832

   ok, makes sense to me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix arrow-json writer empty [arrow-rs]

Posted by "jackkleeman (via GitHub)" <gi...@apache.org>.
jackkleeman commented on PR #6614:
URL: https://github.com/apache/arrow-rs/pull/6614#issuecomment-2538594296

   https://xkcd.com/1172/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org