You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/12 02:44:26 UTC
[GitHub] [spark] yaooqinn opened a new pull request #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
yaooqinn opened a new pull request #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
This is a followup of https://github.com/apache/spark/pull/27867, the issue here is as same as that one, which caused by baning intervals as output.
### Why are the changes needed?
fix test bug
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
re-run IntervalBenchmark
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597978673
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#discussion_r391438006
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DateTimeBenchmark.scala
##########
@@ -114,12 +114,12 @@ object DateTimeBenchmark extends SqlBasedBenchmark {
}
runBenchmark("Parsing") {
val n = 1000000
- val timestampStrExpr = "concat('2019-01-27 11:02:01.', cast(mod(id, 1000) as string))"
+ val timestampStrExpr = "concat('2019-01-27 11:02:01.', rpad(mod(id, 1000), 3, '0'))"
val pattern = "'yyyy-MM-dd HH:mm:ss.SSS'"
Review comment:
one more thought: maybe we should change the pattern string to `yyyy-M-d H\:m:s.S`, to match the behavior of 2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598038263
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119691/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598171653
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598148799
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598148802
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119700/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
cloud-fan removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598051985
A high-level comment: "Optimize Local Shuffle Reader" should be a sub-feature of converting SMJ to BHJ. We should mention that instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598036352
**[Test build #119700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119700/testReport)** for PR 27885 at commit [`7a52ce7`](https://github.com/apache/spark/commit/7a52ce798dbc011e3aebf28bdb07cf6fe2751769).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598050336
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598051985
A high-level comment: "Optimize Local Shuffle Reader" should be a sub-feature of converting SMJ to BHJ. We should mention that instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598037697
**[Test build #119691 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119691/testReport)** for PR 27885 at commit [`7759b80`](https://github.com/apache/spark/commit/7759b8080962bf97fcf7fdce78072ee2735ebeab).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#discussion_r391438006
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DateTimeBenchmark.scala
##########
@@ -114,12 +114,12 @@ object DateTimeBenchmark extends SqlBasedBenchmark {
}
runBenchmark("Parsing") {
val n = 1000000
- val timestampStrExpr = "concat('2019-01-27 11:02:01.', cast(mod(id, 1000) as string))"
+ val timestampStrExpr = "concat('2019-01-27 11:02:01.', rpad(mod(id, 1000), 3, '0'))"
val pattern = "'yyyy-MM-dd HH:mm:ss.SSS'"
Review comment:
one more thought: maybe we should change the pattern string to `yyyy-M-d H:\m:s.S`, to match the behavior of 2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn edited a comment on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597980068
> Hi, @yaooqinn . If this is not the last one, could you proceed as a single PR for all benchmark?
I'll re-run all benchmarks to see if any same issue exists, thank you very much for your advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598148802
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119700/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597980153
**[Test build #119691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119691/testReport)** for PR 27885 at commit [`7759b80`](https://github.com/apache/spark/commit/7759b8080962bf97fcf7fdce78072ee2735ebeab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598036614
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598038256
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598006746
### org.apache.spark.sql.execution.benchmark.DateTimeBenchmark
```scala
[error] Caused by: java.time.format.DateTimeParseException: Text '2019-01-27 11:02:01.0' could not be parsed at index 20
[error] at java.base/java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:2046)
[error] at java.base/java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1874)
[error] at org.apache.spark.sql.catalyst.util.Iso8601TimestampFormatter.$anonfun$parse$1(TimestampFormatter.scala:71)
[error] ... 19 more
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598050346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24434/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598036614
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597980153
**[Test build #119691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119691/testReport)** for PR 27885 at commit [`7759b80`](https://github.com/apache/spark/commit/7759b8080962bf97fcf7fdce78072ee2735ebeab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598148013
**[Test build #119700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119700/testReport)** for PR 27885 at commit [`7a52ce7`](https://github.com/apache/spark/commit/7a52ce798dbc011e3aebf28bdb07cf6fe2751769).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#discussion_r391438006
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DateTimeBenchmark.scala
##########
@@ -114,12 +114,12 @@ object DateTimeBenchmark extends SqlBasedBenchmark {
}
runBenchmark("Parsing") {
val n = 1000000
- val timestampStrExpr = "concat('2019-01-27 11:02:01.', cast(mod(id, 1000) as string))"
+ val timestampStrExpr = "concat('2019-01-27 11:02:01.', rpad(mod(id, 1000), 3, '0'))"
val pattern = "'yyyy-MM-dd HH:mm:ss.SSS'"
Review comment:
one more thought: maybe we should change the pattern string to `yyyy-M-d H:m:s.S`, to match the behavior of 2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598049737
**[Test build #119705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119705/testReport)** for PR 27885 at commit [`4015c76`](https://github.com/apache/spark/commit/4015c76b26cbf56f90208ea3fa36e19cb03d4255).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598027793
@yaooqinn can you point out what query causes this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598171653
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598049737
**[Test build #119705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119705/testReport)** for PR 27885 at commit [`4015c76`](https://github.com/apache/spark/commit/4015c76b26cbf56f90208ea3fa36e19cb03d4255).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598050336
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#discussion_r391439656
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DateTimeBenchmark.scala
##########
@@ -114,12 +114,12 @@ object DateTimeBenchmark extends SqlBasedBenchmark {
}
runBenchmark("Parsing") {
val n = 1000000
- val timestampStrExpr = "concat('2019-01-27 11:02:01.', cast(mod(id, 1000) as string))"
+ val timestampStrExpr = "concat('2019-01-27 11:02:01.', rpad(mod(id, 1000), 3, '0'))"
val pattern = "'yyyy-MM-dd HH:mm:ss.SSS'"
Review comment:
It will fail with `2019-01-27 11:02:01.12(123)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597978636
cc @dongjoon-hyun @cloud-fan, thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598050346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24434/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597979542
Hi, @yaooqinn . If this is not the last one, could you proceed as a single PR for all benchmark?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598171665
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119705/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598036623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24429/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597978673
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598148799
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597979823
Also, please create a new JIRA issue. The old one is already committed as `ExtractBenchmark`. So, we cannot reuse the ID for `IntervalBenchmark`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597980068
> Hi, @yaooqinn . If this is not the last one, could you proceed as a single PR for all benchmark?
I'll re-run all benchmark to see if any same issue exists, thank you very much for your advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598170742
**[Test build #119705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119705/testReport)** for PR 27885 at commit [`4015c76`](https://github.com/apache/spark/commit/4015c76b26cbf56f90208ea3fa36e19cb03d4255).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598038263
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119691/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597978677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24420/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-597978677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24420/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598171665
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119705/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27885:
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in
IntervalBenchmark
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27885: [SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in IntervalBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598029090
1. the IntervalBenchmark is as same as the last one in ExtractBenchmark
2. the DateTimeBenchmark fails at `to_timestamp('2019-01-27 11:02:01.0', 'yyyy-MM-dd HH:mm:ss.SSS')`, which maybe should be `to_timestamp('2019-01-27 11:02:01.000', 'yyyy-MM-dd HH:mm:ss.SSS')` @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#discussion_r391438006
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DateTimeBenchmark.scala
##########
@@ -114,12 +114,12 @@ object DateTimeBenchmark extends SqlBasedBenchmark {
}
runBenchmark("Parsing") {
val n = 1000000
- val timestampStrExpr = "concat('2019-01-27 11:02:01.', cast(mod(id, 1000) as string))"
+ val timestampStrExpr = "concat('2019-01-27 11:02:01.', rpad(mod(id, 1000), 3, '0'))"
val pattern = "'yyyy-MM-dd HH:mm:ss.SSS'"
Review comment:
one more thought: maybe we should change the pattern string to `yyyy-M-d H: m:s.S`, to match the behavior of 2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598038256
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598036352
**[Test build #119700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119700/testReport)** for PR 27885 at commit [`7a52ce7`](https://github.com/apache/spark/commit/7a52ce798dbc011e3aebf28bdb07cf6fe2751769).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27885:
[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27885: [SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark
URL: https://github.com/apache/spark/pull/27885#issuecomment-598036623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24429/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org