You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/11/22 18:40:43 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade

rhtyd commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade
URL: https://github.com/apache/cloudstack/pull/3695#discussion_r349738596
 
 

 ##########
 File path: debian/cloudstack-usage.postinst
 ##########
 @@ -40,7 +35,7 @@ case "$1" in
 
         # Replacing key with management server key
         if [ -f "/etc/cloudstack/management/key" ]; then
-            rm -rf /etc/cloudstack/usage/key
+            rm -f /etc/cloudstack/usage/key
             ln -s /etc/cloudstack/management/key /etc/cloudstack/usage/key
 
 Review comment:
   Yes. I'm not sure if the file being removed may not be a symlink, this approach should work as intended. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services